id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-1-d617193c | DERBY-2020 (partial) Move check for JVM bug (DERBY-1) into separate method.
Patch contributed by Olav Sandstå.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@530807 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java",
"hunks": [
{
"added": [
" /**",
" * Status for whether the check on the sync error on some JVMs has been",
" * done or not. See the checkJvmSyncError method for details.",
... |
derby-DERBY-1001-5e009439 | (DERBY-1001): Removed two unused imports and renamed a local variable hiding an instance variable.
Patch file: n/a
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@666583 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1002-f0dcf0bb | DERBY-1002 - Check that DRDAStatement and DRDAResultSet states are reset when they are re-used
Contributed by Deepa Remesh
Please take a look at following two patches - patch 1 contains code changes and patch 2 contains tests. These have to be committed together.
------------------------------------------
1. derby1002-patch1-v1
------------------------------------------
* Adds reset() methods to DRDAStatement and DRDAResultSet objects. The purpose of reset method is to reset the states of all variables so that the objects can be re-used and will not have left-over states.
* In case of DRDAStatement, the following variables are not reset:
+ * 1. database - This variable gets initialized in the constructor and by
+ * call to setDatabase.
+ * 2. members which get initialized in setPkgnamcsn (pkgnamcsn, pkgcnstkn,
+ * pkgid, pkgsn, isolationLevel, cursorName). pkgnamcsn is the key used to
+ * find if the DRDAStatement can be re-used. Hence its value will not change
+ * when the object is re-used.
* close() methods are changed to only close and dereference objects.
* DRDAStatement.rsClose() method is not used in close() or reset(). This method has some checks which were causing the method to return without resetting currentDrdaRs. Now, close() calls currentDrdaRs.close() and reset() calls currentDrdaRs.reset().
* In Database.newDrdaStatement, close() method is called followed by reset() when the server finds the statement can be re-used.
------------------------------------------
2. derby1002-patch2-v2
------------------------------------------
Modifies test lang/procedure.java. Adds a method 'setupStatementReuse' which creates and uses statements in such a way as to provoke re-use of statements and result sets on network server. This method is called from tests for jira-491 and 'testImplicitClose'.
------------------------------------------------------------------------------------
Remaining TODOs for DERBY-1002
------------------------------------------------------------------------------------
* pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
* Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@381937 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAResultSet.java",
"hunks": [
{
"added": [
"\t//NOTE!",
"\t//",
"\t// Since DRDAResultSets are reused, ALL variables should be set ",
"\t// to their default values in reset()."
],
"header"... |
derby-DERBY-1004-494a3289 | DERBY-1004: Client should not require user to rollback the active transaction before call to PooledConnection.getConnection()
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@412852 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/ClientPooledConnection.java",
"hunks": [
{
"added": [
" } "
],
"header": "@@ -178,7 +178,7 @@ public class ClientPooledConnection implements javax.sql.PooledConnection {",
"removed": [
... |
derby-DERBY-1005-fdfc981e | DERBY-966 DERBY-1005 1) Change DRDAStatement to use the EngineConnection.prepareStatement() method that has a holdability parameter. This ensures prepares on a connection that was obtained from a XADataSource (or a ConnectionPoolDataSource) do not lose the holdability requested by the application.
2) Change the client's state of holdability to match the embedded in that a Connection's holdability is set to close cursors on commit when it has an active global XA transaction.
Patch addresses this issue completely.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@380278 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
"import org.apache.derby.shared.common.reference.JDBC30Translation;"
],
"header": "@@ -21,6 +21,7 @@",
"removed": []
},
{
"added": [
" ... |
derby-DERBY-1006-4388f151 | DERBY-1006 Disallow holdable cursor setting at the connection and statement
level while in a global transaction for the client driver. Matches the embedded
as the holdable cursors are not supported in global (XA) transactions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@381549 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
" // In an XA global transaction do not allow the",
" // holdability to be set to hold cursors across",
" // commits, as the engine does no... |
derby-DERBY-1007-ab10884c | DERBY-1007: Fix optimizer to make subqueries return correct cost estimates.
More description of the changes:
1. Added the "prepForNextRound()" method that was part of OptimizerImpl
to the Optimizer interface since that seemslike an appropriate place for it.
2. Added a single line to OptimizerImpl.prepForNextRound() to reset the "bestCost"
for the current round of optimization. Note that I do _not_ reset the "foundABestPlan"
variable nor the "bestJoinOrder" array. This is because it's possible that a
"best join order" may not exist for the current round, in which case the optimizer
must know whether or not it found a best join order in a previous round
(foundABestPlan) and if so what the corresponding join order was (bestJoinOrder).
That information is required so that a valid query plan can be generated after
optimization is complete.
3. After making the above changes, I noticed that the optimizer cost
estimates were not always showing up when logQueryPlan was set to true--they
were sometimes being printed as question marks to represent "Infinity". The reason
for this was that most of the code in the "modifyAccessPaths" phase of query
compilation uses the estimates as they sit in the ResultSetNode.costEstimate
field--which, for nodes above subqueries, will hold the "bestCost" estimates for
the most recent plan chosen by the OptimizerImpl for the subquery. Since I am now
(with DERBY-1007) resetting the "bestCost" variable at the start of every round,
it's possible that "bestCost" will hold an estimate that has been "reset" to
Double.MAX_VALUE. This can happen if it was reset (in prepForNextRound()) and
then no valid join order was found for the current round (ex. if no valid join
order exists or if there was an optimizer "timeout"). That in turn meant that
the "costEstimate" field for nodes above the OptimizerImpl would have been "reset"
as well, and hence the "infinity" value (i.e. question mark) was showing up in the
logged query plan. So I had to find all nodes that use "costEstimate" during
modifyAccessPaths() and update them to use the final, best cost estimate for
that node (instead of just using the most recent value of "costEstimate"). This
touched several of ResultSetNode's subclasses, but the diff in most cases is just
a few lines. The exceptions are FromTable, SelectNode, UnionNode,
IntersectOrExceptNode, and JoinNode, where I added new "getFinalCostEstimate" methods
to correctly figure out the final cost estimate based on the final estimates for
child nodes, as appropriate.
4. The current optimizer "timeout" mechanism is based on the value in
OptimizerImpl.bestCost. Since I'm now resetting that value at the start of every
round, the timeout mechanism had to be changed in order to preserve its current
functionality while removing the dependency on bestCost. So I've added a new
variable, timeLimit, to OptimizerImpl that plays the same role w.r.t optimizer
"timeout" that the old bestCost value did.
5. Updated master/derived.out to match new behavior. There's one query in
derived.sql that is affected by this issue. Before these changes the optimizer
thought one join order B was cheaper than another join order A and so it chose
to generate join order B. With these changes, though, it now (correctly) sees that
join order A and join order B are equivalent, so it just goes with join order A.
This difference manifests itself in the ordering of two rows in the result set for
that query--so I've updated the masters accordingly.
6. Added a new, simple test case specific to DERBY-1007 to lang/subquery.sql, and
updated the master file accordingly. The test case is the same one mentioned in the
description for this issue.
Submitted by Army Brown (qozinx@sbcglobal.net)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@382935 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/IntersectOrExceptNode.java",
"hunks": [
{
"added": [
"\t\t// Get our final cost estimate based on the child estimates.",
"\t\tcostEstimate = getFinalCostEstimate();",
""
],
"header": "@@ -330... |
derby-DERBY-1007-e540aee4 | DERBY-1007: Follow up patch to earlier submitted patch.
In a word, the fix for this issue ensures that, in the case of subqueries, the optimizer will correctly propagate the estimated costs for subqueries up to the parent subquery(-ies), thus allowing the parent query to make a better decision about which join order is ultimately the best. As seen in the example scenario included above, the correct estimates are higher--sometimes much higher--than what the optimizer was returning prior to this change: in the example, the optimizer was returning an incorrect cost estimate of 10783 before the patch, and a correct estimate of 1 million after the patch (where "correct" means that it's the value calculated by the optimizer and thus the value that should be returned; I'm not saying anything about the accuracy of the estimate here).
One side effect of this is that, for very deeply nested queries and/or queries with a high number of FROM tables/expressions, the higher cost estimates can be multiplied--sometimes many times over--throughout the optimization process, which means that the overall query estimate can climb to a much larger number much more quickly. If the query is big enough, this can actually cause the optimizer to reach an estimated cost of INFINITY.
That said, the current optimizer logic for choosing a plan does not expect to see an estimate of infinity for its plans. As a result the optimizer does comparisons of, and arithmetic with, cost estimates and row counts that, when applied to Infinity, give unexpected results.
I have filed DERBY-1259 and DERBY-1260 to address the "infinity problem" in more detail, but am attaching here a follow-up patch that takes some basic steps toward making the optimizer more robust in the face of infinite cost estimates, which are now more likely to occur given the DERBY-1007 changes. In particular, the d1007_followup_v1.patch does the following:
1) Fixes a couple of small problems with the handling of estimates for FromBaseTables, to ensure that a FromBaseTable's estimate is correctly propagated to (and handled by) the ProjectRestrictNode that sits above it. This parallels the original DERBY-1007 work but is a much simpler "follow-up" task as it deals only with base tables instead of subqueries, and thus the changes are fairly minor.
2) There are several places in OptimizerImpl where the optimizer will only choose to accept a plan's cost if the cost is less than the current "bestCost". If no best cost has been found yet, bestCost is set to an uninitialized value of Double.MAX_VALUE with the assumption that the first valid plan will have a cost less than Double.MAX_VALUE and thus will be chosen as the best so far. However, since a plan's cost estimate can actually end up being Double.POSITIVE_INFINITY, which is greater than Double.MAX_VALUE, it's possible that the optimizer will reject a valid join order because its cost is infinity, and then end up completing without ever finding a valid plan--which is wrong. What we want is for the optimizer to accept the first valid plan that it finds, regardless of what the cost is. Then if it later finds a better plan, it can use that. So in several places the d1007_followup_v1.patch adds a check to see if bestCost is uninitialized and, if so, we'll always accept the first valid join order we find, regardless of what its cost is--even if it's infinity--because that's better than no plan at all.
3) Modifies the "compare" method in CostEstimateImpl.java to try to account for comparisons between two plans that both have infinite costs. If this happens, we don't have much choice but to guess as to which plan is actually better. So the changes for followup_v1 make that guess based on a comparison of row counts for the two plans. And if the row counts themselves are infinity, then we'll guess based on the single scan row counts. And finally, if those values are both infinity, as well, then we're out of luck and we just say that the two costs are "equal" for lack of better alternative.
4) And finally, due to unexpected behavior that results from arithmetic using infinity (see DERBY-1259), it is currently possible (though rather rare) for the optimizer to decide to do a hash join that has a cost estimate of Infinity. An example of a query for which this could happen can be found in DERBY-1205, query #1. That said, the BackingStoreHashtable that is used for carrying out a hash join currently creates a Java Hashtable instance with a capacity that matches the optimizer's estimated row count. So if the row count is infinity we'll try to create a Hashtable with some impossibly large capacity and, as a result, we'll end up with an OutOfMemory error. So the d1007_followup_v1.patch adds some code to handle this kind of situation in a more graceful manner.
I ran derbyall with these changes on Linux Red Hat using ibm142 and saw no new failures.
Submitted by Army Brown (qozinx@gmail.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@397675 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/access/BackingStoreHashtable.java",
"hunks": [
{
"added": [
" /* We want to create the hash table based on the estimated row",
" * count if a) we have an estimated row count (i.e. it's greater",
... |
derby-DERBY-1009-6d12993a | DERBY-434 DERBY-1009 DERBY-435
Remove static check methods with duplicated code in instance methods,
have the Java procedure call the instance method for the connection checks
on the nested connection.
Have the checkDataSource30 procedure nested connection checks use checkDataSource30 as
the object for the instance method, adds the holdability and savepoint tests for checkDataSource30.
Add test of the return of ResultSet.getStatement to expose DERBY-1009.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@378797 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1009-e65be5ba | DERBY-1009 Ensure EmbedResultSet.getStatement() returns the BrokeredStatement object
the application used to create it, rather than the underlying physical statament.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379178 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/jdbc/BrokeredPreparedStatement.java",
"hunks": [
{
"added": [
"\tfinal String\tsql;"
],
"header": "@@ -38,7 +38,7 @@ public class BrokeredPreparedStatement extends BrokeredStatement",
"removed": [
"\tprote... |
derby-DERBY-1010-fe35a93d | DERBY-1010 - setTransactionIsolation can cause ava.sql.SQLException: Invalid operation: statement closed in some contexts with xa
Client has a Statement object that it reuses to send SET CURRENT ISOLATION commands to the server. Added a check to make sure this statement was not closed before trying to reuse it.
This change takes the checkDataSource test a bit further (DERBY-435) but there seem to be issues with isolation being set correctly with xa_join. I will investigate that and file a Jira issue
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379993 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1015-3734ddea | DERBY-1015 Use the EngineConnection class to call setDRDAId, set/getPrepareIsolation from
the network server on an embedded connction. Removes the requirement for specialized methods
in XADatasource.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379609 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/Database.java",
"hunks": [
{
"added": [],
"header": "@@ -33,7 +33,6 @@ import java.util.Properties;",
"removed": [
"import org.apache.derby.impl.jdbc.EmbedConnection;"
]
},
{
"added": [
... |
derby-DERBY-1015-4e3b1b6b | DERBY-1015 (partial) Add an interface for Statement objects from the engine, EngineStatement. Removes
some use of reflection in brokered objects and the network server. Is also a step towards solving
DERBY-1158, downgrading holdabilty in global transactions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@391691 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAStatement.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.jdbc.EngineStatement;"
],
"header": "@@ -38,6 +38,7 @@ import java.util.Vector;",
"removed": []
},
{
"added": [
... |
derby-DERBY-1015-aadfd426 | DERBY-1015: Define interface between network server and engine through
Java interfaces. Contributed by Sunitha Kambhampati. Passes
derbynetclientmats.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@421435 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.jdbc.EngineParameterMetaData;"
],
"header": "@@ -56,7 +56,7 @@ import org.apache.derby.iapi.services.monitor.Monitor;",
"removed": [
... |
derby-DERBY-1015-ab40defb | DERBY-1015: Added new interfaces
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@421460 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/jdbc/EnginePreparedStatement.java",
"hunks": [
{
"added": [
"/*",
" ",
" Derby - Class org.apache.derby.iapi.jdbc.EnginePreparedStatement",
" ",
" Copyright 2006 The Apache Software Foundation or its... |
derby-DERBY-1015-af35756e | DERBY-1015 (partial) Minor cleanup in the methods to obtain a connection in the network server.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379551 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/Database.java",
"hunks": [
{
"added": [
"\tvoid setConnection(Connection conn)"
],
"header": "@@ -112,7 +112,7 @@ class Database",
"removed": [
"\tprotected void setConnection(Connection conn)"
... |
derby-DERBY-1015-da847a29 | DERBY-1015 (partial) Initial code for EngineConnection. Add the EngineConnection
interface with a set of initial methods, make EmbedConnection and BrokeredConnection
implement this interface. No uses of the interface added yet. Some of the initial
methods were moved from BrokeredConnectionControl which looked like a start on the
same approach but did not address the issue of a single api for embedded and brokered
connections.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379545 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection.java",
"hunks": [
{
"added": [
"public class BrokeredConnection implements EngineConnection"
],
"header": "@@ -43,7 +43,7 @@ import org.apache.derby.iapi.error.StandardException;",
"removed":... |
derby-DERBY-1015-faf21340 | DERBY-1015 (partial) Modify the network server to hold the embedded Connection
object as a EngineConnection reference instead of a vanilla Connection. Does
not change the uses of the connection reference to take advantage of the consistent
api, will be done in a future patch.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379567 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/Database.java",
"hunks": [
{
"added": [
"",
"import org.apache.derby.iapi.jdbc.EngineConnection;"
],
"header": "@@ -29,6 +29,8 @@ import java.sql.SQLException;",
"removed": []
},
{
"... |
derby-DERBY-1016-418e135a | DERBY-1016; javax.transaction.xa.forget (Xid) raises XAER_NOTA exception instead of XA_PROTO on a prepared transaction
patch contributed by Jayaram Subramanian (rsjay1976 at gmail dot com).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1210686 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1024-d5ba8a8b | DERBY-1024 Remove the XA constants in XAResource that were duplicates of standard
constants from XAException and XAResource. Removed the code that translated (incorrectly)
an XA return value from one constant to another (with the same value in most cases).
Thus fixing 1024 where the incorrect XA code was being thrown, this was because the
unneded conversion code was incomplete.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@380282 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetXAConnection.java",
"hunks": [
{
"added": [
"import javax.transaction.xa.XAException;",
"import javax.transaction.xa.XAResource;"
],
"header": "@@ -22,6 +22,8 @@ package org.apache.derby.client.net;",
... |
derby-DERBY-1025-1a7cb26e | DERBY-1025 - [xa] client XAResource.start() does not commit an active local transaction when auto commit is true
Contributed by Deepa Remesh
------------------------------------------------
Summary:
------------------------------------------------
* Modifies NetXAResource.start to check if the connection is in autocommit mode and flow an auto commit.
* Uncomments the tests for this issue in jdbcapi/XATest.java and jdbcapi/checkDataSource.java
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@394134 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1025-bff53129 | DERBY-1025 / DERBY-2620 test cases
Make sure statement is created with holdability CLOSE_CURSORS_AT_COMMIT when testing if xa_start commits the transaction. Exempt embedded from running DERBY-1025 test because of 08003 - No current connection
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@535973 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1025-c63d941b | DERBY-435 jdbcapi/checkDataSource.java and jdbapi/checkDataSource30.java to tests should be changed or extended to test client DataSources
- Brings checkDataSource and checkDataSourc30 into derbynetclientmats
- Reenables tests for DERBY-1044 now that it is fixed.
Tests are excluded for some bugs uncovered by this test that have yet to
be resolved:
DERBY-1035, DERBY-1047, DERBY-1025, DERBY-1148, DERBY-1183
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@391902 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1025-fa1185de | DERBY-435 continuing work to get checkDataSource running with client
disabled test cases for DERBY-1025, DERBY-1044, and DERBY-1047
added workaround for DERBY-1036 to give statements different cursor names
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@380672 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1030-7d3ddb17 | DERBY-1030 (partial) Add some comments to the logic for the RETURNS ON NULL INPUT's state field.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@475803 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/SQLToJavaValueNode.java",
"hunks": [
{
"added": [
" /**",
" * If set then this SQL value is being passed into a SQL function",
" * declared RETURNS NULL ON NULL input. In this case this node",
... |
derby-DERBY-1030-d2cb094d | DERBY-1030 (partial) Add test cases to RoutineTest that demonstrate this bug, where
a function declared as RETURNS NULL ON NULL INPUT can be called when its argument is NULL.
Look for the comment with this bug number.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@475490 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1035-93abf18b | Disable tests for setting isolation with an SQL statement for client until DERBY-1035 is fixed
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@380020 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1035-ac53be6a | DERBY-1148 Client XA getTransactionIsolation() does not return the correct isolation level when rejoining a global transaction
Contributed by Deepa Remesh
Summary of patch:
* Changes getTransactionIsolation method in org.apache.derby.client.am.Connection class to get the isolation level from server. The built-in function "CURRENT ISOLATION" is used for this. It throws SQLException in case of failures. At the start of the method, the current auto-commit value is stored in a variable. When executing the function, auto-commit is set to false. At the end of the method, auto-commit value is restored. As it is the client which drives the auto-commit, this strategy of locally changing the auto-commit works.
* Removes the excludes for DERBY-1148 and DERBY-1035 from checkDataSource test. Adds a test for transaction suspend/resume in checkDataSource test. Updates master files
With this patch, I have run derbynetclientmats with Sun jdk 1.4.2 on Windows XP. I also ran checkDataSource.java and checkDataSource30.java with embedded and client framework. No failures
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@409470 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
" ",
" // used to get transaction isolation level",
" private Statement getTransactionIsolationStmt = null;",
" "
],
"header": "@@ -80... |
derby-DERBY-1035-c63d941b | DERBY-435 jdbcapi/checkDataSource.java and jdbapi/checkDataSource30.java to tests should be changed or extended to test client DataSources
- Brings checkDataSource and checkDataSourc30 into derbynetclientmats
- Reenables tests for DERBY-1044 now that it is fixed.
Tests are excluded for some bugs uncovered by this test that have yet to
be resolved:
DERBY-1035, DERBY-1047, DERBY-1025, DERBY-1148, DERBY-1183
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@391902 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1037-61634ec3 | DERBY-1037: Fix lang/ShutdownDatabase.java in J2ME environment.
Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@386218 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1039-b9ee498b | DERBY-1039, committed on behalf of Suresh Thalamati
-- database create will fail with error if the user specified logDevice location
already contains non-empty "log" dir at that location.
-- added a new test that tests database creation with logDevice location
with absolute paths and also the above expected error case.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@397011 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java",
"hunks": [
{
"added": [
"",
"",
" /**",
" * Create the directory where transaction log should go.",
" * @exception StandardException Standard Error Policy",
... |
derby-DERBY-1040-67225cdc | DERBY-1040; Run store locking tests with network server and investigate locking behaviour
Pushing LockTableVtiTest to run with both embedded and DerbyNetClient/Network Server
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1629764 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1042-31083414 | DERBY-1042: committed on behalf of Suresh Thalamati
I could not reproduce this problem on my machine. By looking at the code I
found backup is getting unblocked before the post commit work is done.
This may cause the error that is reported, if the jar files to copied to the
backup is deleted by the post commit. Attached patch unblocks the backup
only after the post commit work that is schedules to run in the same
transaction is done. While scanning the code for this problem, I also noticed
couple of other small issues, this patch addresses them also.
DERBY-1042:
-- unblock the backup only after the post commit work to be done on the same
transaction is complete.
-- when backup is in progress drop stub files are not deleted during
checkpoint. These are necessary to perform recovery starting from the
backup checkpoint.
-- synchronized getContaineNames() that gets the containers to be written to
the backup. This method need to be synchronized so that other privileged
actions does not run in parallel and vice versa.
-- Modified the OnlineBackupTest1.java and OnlineBackupTest3.java tests to
abort if there is a error during the backup instead of waiting incorrectly
for the failed backup to complete forever.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@384661 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/xact/Xact.java",
"hunks": [
{
"added": [],
"header": "@@ -1911,10 +1911,6 @@ public class Xact extends RawTransaction implements Limit {",
"removed": [
"\t\t// any backup blocking operations (like unlogged ops) i... |
derby-DERBY-1043-e2cf840c | DERBY-1043 Invalid column references are not caught in a trigger action statement when the referencing table of the column is the triggered table. Contributed by Fernanda Pizzorno.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@418933 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/UpdateNode.java",
"hunks": [
{
"added": [
"\t\t * the table name out from each RC. See comment on ",
"\t\t * checkTableNameAndScrubResultColumns().",
"\t\tcheckTableNameAndScrubResultColumns(resultColumnList... |
derby-DERBY-1044-c63d941b | DERBY-435 jdbcapi/checkDataSource.java and jdbapi/checkDataSource30.java to tests should be changed or extended to test client DataSources
- Brings checkDataSource and checkDataSourc30 into derbynetclientmats
- Reenables tests for DERBY-1044 now that it is fixed.
Tests are excluded for some bugs uncovered by this test that have yet to
be resolved:
DERBY-1035, DERBY-1047, DERBY-1025, DERBY-1148, DERBY-1183
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@391902 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1044-fa1185de | DERBY-435 continuing work to get checkDataSource running with client
disabled test cases for DERBY-1025, DERBY-1044, and DERBY-1047
added workaround for DERBY-1036 to give statements different cursor names
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@380672 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1047-b01ccf59 | DERBY-1196 Network server closes prepared statements prematurely if exception occurs during OPNQRY
- Takes out close of prepared statement on exception in OPNQRY in DRDAConnThread processCommands
- Updates the JCC master for derbnet/setTransactionIsolation.
This test was getting Statement already closed errors for valid statements with JCC that are no longer in the master.
- Enables test for DERBY-1047 in checkDataSource ( Note this case actually passes withtout the fix because of the fix for DERBY-1158)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@392781 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1047-c63d941b | DERBY-435 jdbcapi/checkDataSource.java and jdbapi/checkDataSource30.java to tests should be changed or extended to test client DataSources
- Brings checkDataSource and checkDataSourc30 into derbynetclientmats
- Reenables tests for DERBY-1044 now that it is fixed.
Tests are excluded for some bugs uncovered by this test that have yet to
be resolved:
DERBY-1035, DERBY-1047, DERBY-1025, DERBY-1148, DERBY-1183
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@391902 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1047-fa1185de | DERBY-435 continuing work to get checkDataSource running with client
disabled test cases for DERBY-1025, DERBY-1044, and DERBY-1047
added workaround for DERBY-1036 to give statements different cursor names
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@380672 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1052-4a95eeb4 | DERBY-434 DERBY-1052: Fix XA tests in remote server testing.
Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@386221 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/TestUtil.java",
"hunks": [
{
"added": [
"\t\t// for remote server testing, check whether the hostName is set for the test",
"\t\t// if so, and serverName is not yet set explicitly for the datasource, set it ... |
derby-DERBY-1055-7a20f8d1 | DERBY-1055 Security.AccessControlException in client under SecurityManager when trying to connect using EUSRIDPWD security mechanism
Contributed by Sunitha Kambhampati
Patch
- removes the unnecessary addProvider call in EncryptionManager that was causing
the Security.AccessControlException.
- enables test to connect using EUSRIDPWD mechanism and updates necessary masters
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@382911 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1060-8d6d99d4 | DERBY-1060: ResultSet methods should throw exception when the
ResultSet is closed
The patch adds calls to checkIfClosed (embeddded) or
checkForClosedResultSet (network client) in the ResultSet methods
which don't check whether the ResultSet is closed. It also adds a test
case to jdbc4/TestResultSetMethods.java.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@383394 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ResultSet.java",
"hunks": [
{
"added": [
" /**",
" * Returns the first <code>SQLWarning</code> reported on this",
" * <code>ResultSet</code> object, or <code>null</code> if there",
" * are ... |
derby-DERBY-1062-3082e5d2 | DERBY-1062: Escape special characters in table name and schema name before passing them on to ALTER TABLE
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@658604 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
" String escapedSchema = escapeSQLIdentifier(schema);",
" String escapedTableName = escapeSQLIdentifier(tablename);",
" \"alter table \" + esca... |
derby-DERBY-1062-7bf9b221 | Cleaning for sqlgrammar.jj a little bit by removing the code to pass the parameters which never will be
set during ALTER TABLE when we are doing a non-compress operation on the table. This is for DERBY-1062
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@657154 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/AlterTableNode.java",
"hunks": [
{
"added": [],
"header": "@@ -160,10 +160,6 @@ public class AlterTableNode extends DDLStatementNode",
"removed": [
"\t * @param sequential\t\tWhether or not the COMPRESS is SEQUE... |
derby-DERBY-1062-818fd271 | This commit is for DERBY-1062. Currently SYSCS_INPLACE_COMPRESS_TABLE is implemented on it's own in
OnlineCompress.java It will be nice for us to share the existing code for ALTER TABLE so we do all the
necessary checks that are already done in ALTER TABLE rather than repeat the code in OnlineCompress.
Another procedure similar to SYSCS_INPLACE_COMPRESS_TABLE is SYSCS_COMPRESS_TABLE and
SYSCS_COMPRESS_TABLE is written using the ALTER TABLE code. With this commit, I am getting rid of
OnlineCompress.java and moving the necessary code into ALTER TABLE related classes. One thing that
SYSCS_INPLACE_COMPRESS_TABLE allows is compressing tables in SYSTEM schemas. The compile code currently
throws an exception if the operation is being done on system schema for DDLs. I had to make changes
such that we allow SYSTEM schema handling in DDL.
This sharing of code also fixes the GRANT/REVOKE code for SYSCS_INPLACE_COMPRESS_TABLE. Earlier we didn't
look for permissions when letting a user issue SYSCS_INPLACE_COMPRESS_TABLE. But now since we use the
existing code in ALTER TABLE, it already handles the permission issues.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@655980 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/AlterTableNode.java",
"hunks": [
{
"added": [
"\t//The following three (purge, defragment and truncateEndOfTable) apply for ",
"\t//inplace compress",
"\tpublic\tboolean\t\t\t\tpurge = false;",
"\t... |
derby-DERBY-1062-8fb718fa | Taking care of javadoc warnings caused by a checkin made for DERBY-1062
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@656323 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/AlterTableConstantAction.java",
"hunks": [
{
"added": [],
"header": "@@ -588,9 +588,6 @@ class AlterTableConstantAction extends DDLSingleTableConstantAction",
"removed": [
" * @param schemaName schema... |
derby-DERBY-1062-ec55311e | DERBY-3674
Inplace compress test in store/TransactionTable.sql started failing after the checkin for DERBY-1062.
Prior to the fix for DERBY-1062, an inplace compress request on VTI would return with no exception
although the code just ignored the compress request on VTI. After DERBY-1062 fix, Derby started
throwing exception. With the changes going through this commit, I am restoring the behavior to no-op
on inplace compress on VTI. I am doing this by making the check for VTI in SystemProcedure and returning
from it if it is a VTI. All the other inplace compress request get fulfilled through internal
generation of ALTER TABLE sql.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@656797 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.store.access.TransactionController;",
"import org.apache.derby.iapi.sql.dictionary.DataDictionary;",
"import org.apache.derby.iapi.sql.dic... |
derby-DERBY-1063-50e065b7 | DERBY-1063: Change server command in derbyrun.jar to server instead of
NetworkServerControl. Touch up the javadoc.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@395434 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/iapi/tools/run.java",
"hunks": [
{
"added": [
" <p>",
" <p>",
" java -jar derbyrun.jar ij [-p propertiesfile] [sql script]<br>",
" java -jar derbyrun.jar sysinfo [-cp ...] [-cp help]<br>",
" java -jar... |
derby-DERBY-1063-83db8d61 | DERBY-1063: Modify derbyrunjartest to call org.apache.derby.iapi.run directly
if it is not in a jar file. Hook the test into the tools suite.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@395453 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1063-8750f312 | DERBY-1063: Add derbyrun.jar - new jar file to execute tools with java -jar
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@384101 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/iapi/tools/run.java",
"hunks": [
{
"added": [
" Derby - Class org.apache.derby.iapi.tools.run"
],
"header": "@@ -1,6 +1,6 @@",
"removed": [
" Derby - Class org.apache.derby.tools.iapi.run"
]
},... |
derby-DERBY-1071-3374162d | DERBY-1071 submitting on behalf of Sunitha Kambhampati.
Derby passes the user in a connection request as is; to the authenticateUser method. Thus if user attribute value is delimited with quotes, the userName in authenticateUser will also be delimited. Mentioned this explicitly in the javadoc.
Javadoc change only.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@382502 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/authentication/UserAuthenticator.java",
"hunks": [
{
"added": [
" * <i>Note</i>: Additional connection attributes can be specified on the ",
" * database connection URL and/or Properties object on jdbc connection. Values"
],
... |
derby-DERBY-1071-a5f9148b | DERBY-1071 submitted on behalf of Sunitha Kambhampati
javadoc fixes from the UserAuthenticator class.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@386463 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/authentication/UserAuthenticator.java",
"hunks": [
{
"added": [
" * <code>jdbc:derby:testdb;user=Fred;password=ScT7dmM2</code>",
" * then the userName will be Fred and within the Derby user authorization ",
" * s... |
derby-DERBY-1079-54792bee | DERBY-1079: Commit bug1079_clientPublicAPI, adding javadoc for client classes in our public api.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@397650 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/ClientDataSource.java",
"hunks": [
{
"added": [
" * ClientDataSource is a simple data source implementation",
" * that can be used for establishing connections in a",
" * non-pooling, non-distributed environment.",
... |
derby-DERBY-1079-b33b410a | DERBY-1079: Expand public API javadoc for visible JDBC4 classes in the embedded client.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@394780 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/jdbc/EmbeddedXADataSource40.java",
"hunks": [
{
"added": [
"",
"\tEmbeddedXADataSource40 is Derby's XADataSource implementation for JDBC4.0.",
"\t",
"",
"\t<P>An XADataSource is a factory for XAConnection... |
derby-DERBY-1080-25dfe8ce | DERBY-1080: Connection reset when using security mechanism=EUSRIDPWD results in protocol error
Patch contributed by Sunitha Kambhampati
For eusridpwd case, the client sends the encrypted userid and password
sectkns as part of SECCHK. The protocol error was happening because we
only read the 2 sectkns if the database.decryptedUserId ,
database.decryptedPassword is null, otherwise we think we have already
read this. Thus on a connection reset,if the decryptedUserId and
decryptedPassword are not reset, server assumes we have seen more SECTKN's
and thus we throw error too many codepoints.
Patch adds
-- code to reset the security mechanism related variables on a connection re-use
-- regression test to testSecMec.java
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@385857 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1087-f4fc366c | DERBY-1087 Updatable result sets behave different depending on the type of query used to generate the result set. Submitted by Fernanda Pizzorno
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@406683 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/IndexRowToBaseRowResultSet.java",
"hunks": [
{
"added": [],
"header": "@@ -105,17 +105,6 @@ public class IndexRowToBaseRowResultSet extends NoPutResultSetImpl",
"removed": [
"\t// for scrollable insensitive upda... |
derby-DERBY-1091-3b16bbd7 | DERBY-1091: Don't prepend a caret to jvmflags in RunSuite if the system
properties are empty, but the suite property is not. Fixes several tests
for J2ME (j9_foundation).
Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@427190 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/RunSuite.java",
"hunks": [
{
"added": [
"\t\tif (jvmflags != null)",
"\t\t\tif (jflags != null)",
"\t\t \t\tsuiteProperties.put(\"jvmflags\", (jvmflags + \"^\" + jflags));",
"\t\t\t... |
derby-DERBY-1091-c92a9b38 | DERBY-1091: Test harness does not pass jvm flags properly if there are more
than 1 property in jvm flags
Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@420048 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/RunSuite.java",
"hunks": [
{
"added": [],
"header": "@@ -93,7 +93,6 @@ public class RunSuite",
"removed": [
"\t\t\t\t//jvmflags = \"-Xiss16k -Xss512k -Xmso16k -Xmx392388k\";"
]
},
... |
derby-DERBY-1095-0c13195e | DERBY-1095 (partial) Clean up close methods on EmbedResultSet, mark the ResultSet
as closed (isClosed=true) once it discovers its Connection is closed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@385570 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java",
"hunks": [
{
"added": [
" ",
" /**",
" * Set if this ResultSet is definitely closed.",
" * If the connection has been closed, or the database",
" * or sy... |
derby-DERBY-1095-5781f54d | DERBY-1095 (partial): Closing an embedded connection does not seem to
close associated EmbedStatements
This patch makes EmbedResultSet.isClosed() return the correct result
when the connection is closed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@388093 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1095-5a50776e | DERBY-1095 (partial) Ensure StatementContexts and CompilerContexts are popped from
context manager on a session close.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@385569 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CompilerContextImpl.java",
"hunks": [
{
"added": [
" ",
" int severity = se.getSeverity();",
"\t\t\tif (severity < ExceptionSeverity.SYSTEM_SEVERITY) "
],
"header": "@@ ... |
derby-DERBY-1095-7a8d0231 | DERBY-1095 (partial) Once a ContextManager is empty no longer maintain a reference
to it in the thread local variable. Avoids a thread hanging onto memory for ever.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@388626 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/context/ContextService.java",
"hunks": [
{
"added": [
"\t\t\tif (--cm.activeCount == 0) {",
" ",
" // If the ContextManager is empty",
" // then don't keep... |
derby-DERBY-1095-8a059c40 | DERBY-1095 Cleanup ContextManagers created during database boot.
Add some comments and synchronization to ContextService.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@387264 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/context/ContextService.java",
"hunks": [
{
"added": [
" /**",
" * Collection of all ContextManagers that are open",
" * in the complete Derby system. A ContextManager is",
" * added whe... |
derby-DERBY-1095-913815a1 | DERBY-1095 (partial) Ensure on a close connection/session contexts are popped off the
context manager. This ensures that references to database wide objects
are not maintained after a close connection.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@384900 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/loader/ClassFactoryContext.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.error.ExceptionSeverity;",
"",
" * Context that provides the correct ClassFactory for the",
" * current service.... |
derby-DERBY-1095-b7df3e85 | DERBY-1095 (partial) Ensure DataDictionaryContexts are popped off the stack
when the connection/session is closed. Cleanup unused code of nested DataDictionaryContexts.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@385106 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryContextImpl.java",
"hunks": [
{
"added": [],
"header": "@@ -42,11 +42,6 @@ class DataDictionaryContextImpl",
"removed": [
"\t//",
"\t// True means this is a nested data dictionary. We pop... |
derby-DERBY-1101-c7d6c758 | DERBY-1101 Modify EmbedResultSet.getHoldability() so that it uses getActivation() instead of getStatement().
Contributed by Knut Anders Hatlen knut.hatlen@sun.com
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@391846 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.reference.JDBC30Translation;"
],
"header": "@@ -48,6 +48,7 @@ import org.apache.derby.iapi.services.io.NewByteArrayInputStream;",
"rem... |
derby-DERBY-1101-d99b5c9f | DERBY-1101 (partial): ResultSet.getHoldability will return incorrect
value when the ResultSet is obtained from a procedure call
Adding a regression test for this issue. The test does not fail, since
the bug won't be exposed until DERBY-1111 is fixed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@388144 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1102-128eeb6e | DERBY-1102 More progress in converting triggerGeneral to Junit, testing of ordering of triggers with constraints.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@523935 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1102-13e0e08a | DERBY-1102 (partial) Add more tests cases for all data types (including streaming values) in action statements.
Add tests for trigger ordering.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@509421 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1102-648b4c12 | DERBY-1102 (partial) Remove unused code in Triggers.java
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@385383 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/Triggers.java",
"hunks": [
{
"added": [],
"header": "@@ -117,14 +117,6 @@ public class Triggers",
"removed": [
"\t// used for performance numbers",
"\tpublic static void zipThroughTriggerResu... |
derby-DERBY-1102-8aa8c9b0 | DERBY-1102 (partial) Add an initial TriggerTest. Only fixture is to ensure that all datatypes
work in an action statement.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@508442 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1102-962234bf | DERBY-1102 (partial) Remove application code that printed the trigger information using
non-public apis.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@385377 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/Triggers.java",
"hunks": [
{
"added": [],
"header": "@@ -40,7 +40,6 @@ public class Triggers",
"removed": [
"\t\tTriggerExecutionContext tec = Factory.getTriggerExecutionContext();"
]
},
... |
derby-DERBY-1102-9a55713e | DERBY-1102 (partial) Remove test case of use of stale TriggerExecutionContext in triggerGeneral.sql
because applications no longer have access to the TriggerExecutionContext.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@385389 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/Triggers.java",
"hunks": [
{
"added": [
"\tprivate Triggers()"
],
"header": "@@ -30,11 +30,7 @@ import java.math.BigInteger;",
"removed": [
"",
"\t// used for threading test... |
derby-DERBY-1102-a7f52a6e | DERBY-1102 Add missing classes for TriggerTest and latest version of test with reference to DERBY-2350.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@508639 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/streams/StringReaderWithLength.java",
"hunks": [
{
"added": [
"package org.apache.derbyTesting.functionTests.util.streams;",
"",
"import java.io.StringReader;",
"",
"public clas... |
derby-DERBY-1102-dda212db | DERBY-1102 (partial) Remove triggerStream test, test of data types in action statement is now in TriggerTest
and covers more situations using the correct apis. Found two or three bugs with the new test.
Remove old utility code that used the old TriggerExecutionContext api.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@509423 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/StreamUtil.java",
"hunks": [
{
"added": [],
"header": "@@ -1,198 +0,0 @@",
"removed": [
"/*",
"",
" Derby - Class org.apache.derbyTesting.functionTests.util.StreamUtil",
... |
derby-DERBY-1102-f6f8e109 | DERBY-1102 (partial) Remove old unused replication related methods in test code Triggers.java
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@385379 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/Triggers.java",
"hunks": [
{
"added": [],
"header": "@@ -52,27 +52,6 @@ public class Triggers",
"removed": [
"\tpublic static void triggerFiresRep(String string) throws Throwable",
"\t{\t",
... |
derby-DERBY-1107-3f523e62 | DERBY-1107 For existing databases JDBC metadata queries do not get updated properly between maintenance versions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@712695 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DD_Version.java",
"hunks": [
{
"added": [
"\t\tbootingDictionary.updateMetadataSPSes(tc);"
],
"header": "@@ -340,8 +340,7 @@ public\tclass DD_Version implements\tFormatable",
"removed": [
"\t\t... |
derby-DERBY-1108-4ba425d2 | DERBY-1108 (partial) More datatypes testing in TriggersTest
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@508593 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1111-d99b5c9f | DERBY-1101 (partial): ResultSet.getHoldability will return incorrect
value when the ResultSet is obtained from a procedure call
Adding a regression test for this issue. The test does not fail, since
the bug won't be exposed until DERBY-1111 is fixed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@388144 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1112-81b9853f | DERBY-1112: TemporaryRowHolderResultSet is breaking the contract of
getActivation
The patch modifies the constructors of TemporaryRowHolderImpl so that
they take an Activation instead of a TransactionController. The
transaction controller can still be obtained from the Activation
object. TemporaryRowHolderResultSet now implements getActivation() by
returning the activation of the TemporaryRowHolderImpl that created
it. TemporaryRowHolderImpl and TemporaryRowHolderResultSet are made
package protected.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@388440 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/DeleteResultSet.java",
"hunks": [
{
"added": [
"\t\t\t\trowHolder = new TemporaryRowHolderImpl(activation, properties, "
],
"header": "@@ -318,7 +318,7 @@ class DeleteResultSet extends DMLWriteResultSet",
... |
derby-DERBY-1113-9ae59954 | DERBY-1113, committing on behalf of Suresh Thalamati
The reason for missing log files is truncation logic at checkpoint was
incorrectly deleting the log files that were needed for crash recovery
if the backup is progress at the same time; The first log file that should
not be deleted was incorrectly assigned to the log file number that is yet
to be written to the backup.
Attached patch changes the logic, so that all the log files that are required for both crash recovery and the backup are not deleted. Basically the first log file that should not be deleted is the lowest of first log needed for crash recovery or the log file that is yet to be copied to the backup.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@394981 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java",
"hunks": [
{
"added": [
"\tprivate volatile long logFileToBackup ; "
],
"header": "@@ -462,7 +462,7 @@ public final class LogToFile implements LogFactory, ModuleControl, ModuleSupport",
... |
derby-DERBY-1115-59d98b89 | DERBY-1115 : Add a shell-script test generator for internationalized
messages (client-side only).
This is the script that generates the test source code that is then
run to validate client-side internationalized mesages
A tools/testing
A tools/testing/i18nTestGenerator
A tools/testing/i18nTestGenerator/genClient1.sed
A tools/testing/i18nTestGenerator/genClient2.sed
AM tools/testing/i18nTestGenerator/generateClientMessageTest.sh
AM tools/testing/i18nTestGenerator/README
Moved the sanity package to the shared directory so that I could
use ASSERT in some shared code.
M java/engine/org/apache/derby/iapi/services/sanity/SanityManager.java
D java/engine/org/apache/derby/iapi/services/sanity/SanityState.tmpl
M java/engine/org/apache/derby/iapi/services/sanity/AssertFailure.java
A java/shared/org/apache/derby/shared/common/sanity
AM java/shared/org/apache/derby/shared/common/sanity/SanityManager.java
A java/shared/org/apache/derby/shared/common/sanity/SanityState.tmpl
AM java/shared/org/apache/derby/shared/common/sanity/SanityState.java
AM java/shared/org/apache/derby/shared/common/sanity/AssertFailure.java
M build.xml
M tools/ant/properties/dirs.properties
Modified MessageUtil so that it ASSERTs that the number of parameters
passed in to formatMessage() actually matches the placeholders in the
message string. Also modified the default message string so that it
is something I can look for in my test to tell me something went wrong.
M java/shared/org/apache/derby/shared/common/i18n/MessageUtil.java
Found a bug by running the test, added a message id to the client
properties file
M java/build/org/apache/derbyBuild/splitmessages.java
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@386187 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/sanity/AssertFailure.java",
"hunks": [
{
"added": [
" Copyright 1997, 2006 The Apache Software Foundation or its licensors, as applicable."
],
"header": "@@ -2,7 +2,7 @@",
"removed": [
" Copyr... |
derby-DERBY-1117-50ff0430 | DERBY-1117 - Fix bug in SqlException where we weren't chaining exceptions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@386710 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/SqlException.java",
"hunks": [
{
"added": [
" ",
" this.setThrowable(cause);"
],
"header": "@@ -114,6 +114,8 @@ public class SqlException extends Exception implements Diagnosable {",
"re... |
derby-DERBY-1121-1c4f638d | DERBY-1121: remove redundant check for DERBY-618 in checkDriver.out so the
test will run in a remote server configuration.
Committed for Deepa Remesh <dremesh@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@394815 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1125-fc25cc0e | DERBY-1125 : Revert putting JVMInfo into the shared area, as it causes
jar sealing issues
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@387905 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/shared/org/apache/derby/shared/common/info/JVMInfo.java",
"hunks": [
{
"added": [],
"header": "@@ -1,177 +0,0 @@",
"removed": [
"/*",
"",
" Derby - Class org.apache.derby.shared.common.info.JVMInfo",
"",
" Co... |
derby-DERBY-1127-6eb9730e | DERBY-1127 client gives SqlException for test callable.java and parameterMapping.java on zOS
Contributed by Sunitha Kambhampati
This patch fixes
-- the calls in DateTime to use correct UTF8 encoding as the server expects.
-- adds these two tests (callable.java, parameterMapping.java) to encodingTests
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@395748 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/DateTime.java",
"hunks": [
{
"added": [
"import org.apache.derby.client.net.Typdef;"
],
"header": "@@ -23,6 +23,7 @@ import org.apache.derby.shared.common.i18n.MessageUtil;",
"removed": []
},
{
... |
derby-DERBY-1130-751ab71f | DERBY-1130 Client should not allow databaseName to be set with setConnectionAttributes
Attaching a patch 'd1130-client-v1.diff' which disallows databaseName attribute to be set using setConnectionAttributes method in client data sources. Tests added to jdbcapi/checkDataSource.java.
Contributed by Deepa Remesh
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430641 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/ClientBaseDataSource.java",
"hunks": [
{
"added": [
"import java.sql.SQLException;"
],
"header": "@@ -31,6 +31,7 @@ import java.lang.reflect.Field;",
"removed": []
},
{
"added": [
" ... |
derby-DERBY-1130-924602a3 | DERBY-1130
contributed by Deepa Remesh
Committing patch 'd1130-v2.diff' which ensures that database name set using setConnectionAttributes does not get used by client data sources. Changes are:
1) Appends the attributes in setConnectionAttributes method to database name only if database name has been already set on the data source. This will handle both these cases successfully:
a) When database name is not set as a DataSource property - In this case, if we pass in database name as a connection attribute, it will not get used. databaseName is a required Derby DataSource property. If it is not set, we cannot get a connection using the DataSource. It will fail with the following exception:
08001 - Required Derby DataSource property databaseName not set.
So, there is no need to append the connectionAttributes to the database name variable if databaseName DataSource property is not set. This way, we can avoid using database name in case it is passed in as a connection attribute.
Without the patch, if database name was not set, the code was using "null" as database name and creating a database named null if "create=true" is specified or throwing an exception that it cannot connect to database named null.
b) When database name is set as a DataSource property - In this case, if we pass in database name as a connection attribute, it will not be used. This is because database name set as DataSource property will over-ride it. This case is correctly handled (even without the patch).
2) The exception message is changed to indicate we are referring to "Derby DataSource" property:
08001 - Required Derby DataSource property databaseName not set.
3) Adds test to jdbcapi/checkDataSource.java. Adds a new method "testClientDSConnectionAttributes" which is run only in client framework. Modifies master files.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@438122 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1130-cbc0b445 | Backout change for
DERBY-1130 Client should not allow databaseName to be set with setConnectionAttributes
To address concerns with the patch
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430891 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/ClientBaseDataSource.java",
"hunks": [
{
"added": [],
"header": "@@ -31,7 +31,6 @@ import java.lang.reflect.Field;",
"removed": [
"import java.sql.SQLException;"
]
},
{
"added": [
" ... |
derby-DERBY-1133-21350fd7 | Checkin patch for DERBY-1133: rototills the jdbc4 tests to conform to customary derbyall practices.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@387640 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1133-7cb20d8e | As part of DERBY-1133, remove vacuous test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@387925 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1136-cd15fffc | DERBY-1136: getFloat throws LossOfPrecisionConversionException on MAX_VALUE
This patch contains a regression test for DERBY-1136. The regression test
verifies that we can successfully retrieve a value of Float.MAX_VALUE
from the database using ResultSet.getFloat.
The test runs for both the embedded driver and the DerbyNetClient driver.
The test is dummied out for the JCC driver, since that driver still suffers
from this bug (but we want to share the same set of master files).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@389575 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1141-d1c8b248 | DERBY-1141: Improve usability of running tests with useprocess=false.
Committing patch dated 20060512.
Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@407637 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/RunList.java",
"hunks": [
{
"added": [
" // if useprocess=false, we cannot pass properties on a commandline,",
" // instead we pass absolutely necessary properties directly t... |
derby-DERBY-1142-2f015be9 | DERBY-1142 (partial) Make EmbedResultSet close its activation in the close method when it is
single use ResultSet (e.g. from a Statement.executeQuery()). Otherwise the close of the activation
would be delayed until the EmbedResultSet was garbage collected and subsequent activity on the connection.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@420656 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java",
"hunks": [
{
"added": [
"\t/**",
"\t This activation is set by EmbedStatement",
"\t for a single execution Activation. Ie.",
"\t a ResultSet from a Statement.executeQuery().",
... |
derby-DERBY-1142-68c8e7d8 | DERBY-418: outofmemory error when running large query in autocommit=false mode
DERBY-1142: Metadata calls leak memory
Notify GenericLanguageConnectionContext when activations are marked as
unused, and clean up unused activations when a new one is added.
Patch contributed by Mayuresh Nirhali.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@439279 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/conn/GenericLanguageConnectionContext.java",
"hunks": [
{
"added": [
"\tprivate volatile boolean unusedActs=false;"
],
"header": "@@ -116,6 +116,7 @@ public class GenericLanguageConnectionContext",
"removed": []... |
derby-DERBY-1146-a9217e9e | DERBY-1146: Add SHOW TABLES and DESCRIBE commands to ij.
Committed for Havard Mork <havard.mork@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430177 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/ijException.java",
"hunks": [
{
"added": [
"\tprivate final static String NoSuchTable = \"IJ_NoSuchTable\";"
],
"header": "@@ -53,6 +53,7 @@ public class ijException extends RuntimeException {",
"removed": [... |
derby-DERBY-1147-966d2c39 | Commit Kristian's first patch for DERBY-1147, adding vacuous implementations of missing CallableStatement methods.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@390292 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/CallableStatement40.java",
"hunks": [
{
"added": [
" Copyright 2005, 2006 The Apache Software Foundation or its licensors, as applicable."
],
"header": "@@ -2,7 +2,7 @@",
"removed": [
" Copyright ... |
derby-DERBY-1147-9c14132c | DERBY-1147: Commit Kristian's patch adding embedded and network client support for miscellaneous CallableStatement methods.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@395263 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/CallableStatement.java",
"hunks": [
{
"added": [
"import java.io.Reader;",
"import java.sql.SQLException;",
""
],
"header": "@@ -20,9 +20,11 @@",
"removed": [
"import java.sql.SQLE... |
derby-DERBY-1148-ac53be6a | DERBY-1148 Client XA getTransactionIsolation() does not return the correct isolation level when rejoining a global transaction
Contributed by Deepa Remesh
Summary of patch:
* Changes getTransactionIsolation method in org.apache.derby.client.am.Connection class to get the isolation level from server. The built-in function "CURRENT ISOLATION" is used for this. It throws SQLException in case of failures. At the start of the method, the current auto-commit value is stored in a variable. When executing the function, auto-commit is set to false. At the end of the method, auto-commit value is restored. As it is the client which drives the auto-commit, this strategy of locally changing the auto-commit works.
* Removes the excludes for DERBY-1148 and DERBY-1035 from checkDataSource test. Adds a test for transaction suspend/resume in checkDataSource test. Updates master files
With this patch, I have run derbynetclientmats with Sun jdk 1.4.2 on Windows XP. I also ran checkDataSource.java and checkDataSource30.java with embedded and client framework. No failures
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@409470 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
" ",
" // used to get transaction isolation level",
" private Statement getTransactionIsolationStmt = null;",
" "
],
"header": "@@ -80... |
derby-DERBY-1148-c63d941b | DERBY-435 jdbcapi/checkDataSource.java and jdbapi/checkDataSource30.java to tests should be changed or extended to test client DataSources
- Brings checkDataSource and checkDataSourc30 into derbynetclientmats
- Reenables tests for DERBY-1044 now that it is fixed.
Tests are excluded for some bugs uncovered by this test that have yet to
be resolved:
DERBY-1035, DERBY-1047, DERBY-1025, DERBY-1148, DERBY-1183
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@391902 13f79535-47bb-0310-9956-ffa450edef68
| [] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.