title
stringlengths
1
290
body
stringlengths
0
228k
html_url
stringlengths
46
51
comments
list
pull_request
dict
number
int64
1
5.59k
is_pull_request
bool
2 classes
Add version-specific BibTeX
As pointed out by @lhoestq in #2411, after the creation of the Zenodo DOI for Datasets, a new BibTeX entry is created with each release. This PR adds a version-specific BibTeX entry, besides the existing one which is generic for the project. See version-specific BibTeX entry here: https://zenodo.org/record/481776...
https://github.com/huggingface/datasets/pull/2430
[ "Maybe we should only keep one citation ?\r\ncc @thomwolf @yjernite ", "For info:\r\n- The one automatically generated by Zenodo is version-specific, and a new one will be generated after each release.\r\n- Zenodo has also generated a project-specific DOI (they call it *Concept DOI* as opposed to *Version DOI*), ...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2430", "html_url": "https://github.com/huggingface/datasets/pull/2430", "diff_url": "https://github.com/huggingface/datasets/pull/2430.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2430.patch", "merged_at": "2021-06-08T07:53...
2,430
true
Rename QuestionAnswering template to QuestionAnsweringExtractive
Following the discussion with @thomwolf in #2255, this PR renames the QA template to distinguish extractive vs abstractive QA. The abstractive template will be added in a future PR.
https://github.com/huggingface/datasets/pull/2429
[ "> I like having \"extractive\" in the name to make things explicit. However this creates an inconsistency with transformers.\r\n> \r\n> See\r\n> https://huggingface.co/transformers/task_summary.html#extractive-question-answering\r\n> \r\n> But this is minor IMO and I'm ok with this renaming\r\n\r\nyes i chose this...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2429", "html_url": "https://github.com/huggingface/datasets/pull/2429", "diff_url": "https://github.com/huggingface/datasets/pull/2429.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2429.patch", "merged_at": "2021-05-31T15:57...
2,429
true
Add copyright info for wiki_lingua dataset
https://github.com/huggingface/datasets/pull/2428
[ "Build fails but this change should not be the reason...", "rebased on master", "rebased on master" ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2428", "html_url": "https://github.com/huggingface/datasets/pull/2428", "diff_url": "https://github.com/huggingface/datasets/pull/2428.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2428.patch", "merged_at": "2021-06-04T10:22...
2,428
true
Add copyright info to MLSUM dataset
https://github.com/huggingface/datasets/pull/2427
[ "Build fails but this change should not be the reason...", "rebased on master" ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2427", "html_url": "https://github.com/huggingface/datasets/pull/2427", "diff_url": "https://github.com/huggingface/datasets/pull/2427.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2427.patch", "merged_at": "2021-06-04T09:53...
2,427
true
Saving Graph/Structured Data in Datasets
Thanks for this amazing library! And my question is I have structured data that is organized with a graph. For example, a dataset with users' friendship relations and user's articles. When I try to save a python dict in the dataset, an error occurred ``did not recognize Python value type when inferring an Arrow data ty...
https://github.com/huggingface/datasets/issues/2426
[ "It should probably work out of the box to save structured data. If you want to show an example we can help you.", "An example of a toy dataset is like:\r\n```json\r\n[\r\n {\r\n \"name\": \"mike\",\r\n \"friends\": [\r\n \"tom\",\r\n \"lily\"\r\n ],\r\n \"arti...
null
2,426
false
Fix Docstring Mistake: dataset vs. metric
PR to fix #2412
https://github.com/huggingface/datasets/pull/2425
[ "IMO this PR is ready for review. I do not know why tests fail...", "The CI fail is unrelated to this PR, and it has been fixed on master, merging :)", "> I just have one comment: we use rouge, not rogue :p\r\n\r\nOops!", "rebased on master" ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2425", "html_url": "https://github.com/huggingface/datasets/pull/2425", "diff_url": "https://github.com/huggingface/datasets/pull/2425.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2425.patch", "merged_at": "2021-06-01T08:18...
2,425
true
load_from_disk and save_to_disk are not compatible with each other
## Describe the bug load_from_disk and save_to_disk are not compatible. When I use save_to_disk to save a dataset to disk it works perfectly but given the same directory load_from_disk throws an error that it can't find state.json. looks like the load_from_disk only works on one split ## Steps to reproduce the bug ...
https://github.com/huggingface/datasets/issues/2424
[ "Hi,\r\n\r\n`load_dataset` returns an instance of `DatasetDict` if `split` is not specified, so instead of `Dataset.load_from_disk`, use `DatasetDict.load_from_disk` to load the dataset from disk.", "Thanks it worked!", "Though I see a stream of issues open by people lost between datasets and datasets dicts so ...
null
2,424
false
add `desc` in `map` for `DatasetDict` object
`desc` in `map` currently only works with `Dataset` objects. This PR adds support for `DatasetDict` objects as well
https://github.com/huggingface/datasets/pull/2423
[ "The CI error is unrelated to the PR, merging", "@lhoestq, can we release this feature if you guys are planning for any patch release for Datasets. It'll slow down [#11927](https://github.com/huggingface/transformers/pull/11927) otherwise :/ ", "Sure definitely, having a discrepancy between Dataset.map and Data...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2423", "html_url": "https://github.com/huggingface/datasets/pull/2423", "diff_url": "https://github.com/huggingface/datasets/pull/2423.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2423.patch", "merged_at": "2021-05-31T13:08...
2,423
true
Fix save_to_disk nested features order in dataset_info.json
Fix issue https://github.com/huggingface/datasets/issues/2267 The order of the nested features matters (pyarrow limitation), but the save_to_disk method was saving the features types as JSON with `sort_keys=True`, which was breaking the order of the nested features.
https://github.com/huggingface/datasets/pull/2422
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2422", "html_url": "https://github.com/huggingface/datasets/pull/2422", "diff_url": "https://github.com/huggingface/datasets/pull/2422.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2422.patch", "merged_at": "2021-05-28T15:26...
2,422
true
doc: fix typo HF_MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES
MAX_MEMORY_DATASET_SIZE_IN_BYTES should be HF_MAX_MEMORY_DATASET_SIZE_IN_BYTES
https://github.com/huggingface/datasets/pull/2421
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2421", "html_url": "https://github.com/huggingface/datasets/pull/2421", "diff_url": "https://github.com/huggingface/datasets/pull/2421.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2421.patch", "merged_at": "2021-06-04T09:52...
2,421
true
Updated Dataset Description
Added Point of contact information and several other details about the dataset.
https://github.com/huggingface/datasets/pull/2420
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2420", "html_url": "https://github.com/huggingface/datasets/pull/2420", "diff_url": "https://github.com/huggingface/datasets/pull/2420.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2420.patch", "merged_at": "2021-06-10T12:11...
2,420
true
adds license information for DailyDialog.
https://github.com/huggingface/datasets/pull/2419
[ "Thanks! Can you also add it as metadata in the YAML block at the top of the file?\r\n\r\nShould be in the form:\r\n\r\n```\r\nlicenses:\r\n- cc-by-sa-4.0\r\n```", "seems like we need to add all the other tags ? \r\n``` \r\nif error_messages:\r\n> raise ValueError(\"\\n\".join(error_messages))\r\n...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2419", "html_url": "https://github.com/huggingface/datasets/pull/2419", "diff_url": "https://github.com/huggingface/datasets/pull/2419.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2419.patch", "merged_at": "2021-05-31T13:16...
2,419
true
add utf-8 while reading README
It was causing tests to fail in Windows (see #2416). In Windows, the default encoding is CP1252 which is unable to decode the character byte 0x9d
https://github.com/huggingface/datasets/pull/2418
[ "Can you please add encoding to this line as well to fix the issue (and maybe replace `path.open(...)` with `open(path, ...)`)?\r\nhttps://github.com/huggingface/datasets/blob/7bee4be44706a59b084b9b69c4cd00f73ee72f76/src/datasets/utils/metadata.py#L58", "Sure, in fact even I was thinking of adding this in order t...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2418", "html_url": "https://github.com/huggingface/datasets/pull/2418", "diff_url": "https://github.com/huggingface/datasets/pull/2418.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2418.patch", "merged_at": "2021-06-04T09:55...
2,418
true
Make datasets PEP-561 compliant
Allows to type-check datasets with `mypy` when imported as a third-party library PEP-561: https://www.python.org/dev/peps/pep-0561 MyPy doc on the subject: https://mypy.readthedocs.io/en/stable/installed_packages.html
https://github.com/huggingface/datasets/pull/2417
[ "This is super cool, I love that ❤️ " ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2417", "html_url": "https://github.com/huggingface/datasets/pull/2417", "diff_url": "https://github.com/huggingface/datasets/pull/2417.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2417.patch", "merged_at": "2021-05-28T13:09...
2,417
true
Add KLUE dataset
Add `KLUE (Korean Language Understanding Evaluation)` dataset released recently from [paper](https://arxiv.org/abs/2105.09680), [github](https://github.com/KLUE-benchmark/KLUE) and [webpage](https://klue-benchmark.com/tasks). Please let me know if there's anything missing in the code or README. Thanks!
https://github.com/huggingface/datasets/pull/2416
[ "I'm not sure why I got error like below when I auto-generate dummy data \"mrc\" \r\n```\r\ndatasets.keyhash.DuplicatedKeysError: FAILURE TO GENERATE DATASET !\r\nFound duplicate Key: 0\r\nKeys should be unique and deterministic in nature\r\n```", "> I'm not sure why I got error like below when I auto-generate du...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2416", "html_url": "https://github.com/huggingface/datasets/pull/2416", "diff_url": "https://github.com/huggingface/datasets/pull/2416.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2416.patch", "merged_at": "2021-06-04T17:45...
2,416
true
Cached dataset not loaded
## Describe the bug I have a large dataset (common_voice, english) where I use several map and filter functions. Sometimes my cached datasets after specific functions are not loaded. I always use the same arguments, same functions, no seed… ## Steps to reproduce the bug ```python def filter_by_duration(batch): ...
https://github.com/huggingface/datasets/issues/2415
[ "It actually seems to happen all the time in above configuration:\r\n* the function `filter_by_duration` correctly loads cached processed dataset\r\n* the function `prepare_dataset` is always reexecuted\r\n\r\nI end up solving the issue by saving to disk my dataset at the end but I'm still wondering if it's a bug o...
null
2,415
false
Update README.md
Provides description of data instances and dataset features
https://github.com/huggingface/datasets/pull/2414
[ "Merging since the CI error is unrelated to this PR and has been fixed on master", "Thank you for taking a look at the CI error - I was a bit confused with that. Thanks!" ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2414", "html_url": "https://github.com/huggingface/datasets/pull/2414", "diff_url": "https://github.com/huggingface/datasets/pull/2414.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2414.patch", "merged_at": "2021-06-28T13:04...
2,414
true
AttributeError: 'DatasetInfo' object has no attribute 'task_templates'
## Describe the bug Hello, I'm trying to add dataset and contribute, but test keep fail with below cli. ` RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_<my_dataset>` ## Steps to reproduce the bug It seems like a bug when I see an error with the existing dataset,...
https://github.com/huggingface/datasets/issues/2413
[ "Hi ! Can you try using a more up-to-date version ? We added the task_templates in `datasets` 1.7.0.\r\n\r\nIdeally when you're working on new datasets, you should install and use the local version of your fork of `datasets`. Here I think you tried to run the 1.7.0 tests with the 1.6.2 code" ]
null
2,413
false
Docstring mistake: dataset vs. metric
This: https://github.com/huggingface/datasets/blob/d95b95f8cf3cb0cff5f77a675139b584dcfcf719/src/datasets/load.py#L582 Should better be something like: `a metric identifier on HuggingFace AWS bucket (list all available metrics and ids with ``datasets.list_metrics()``)` I can provide a PR l8er...
https://github.com/huggingface/datasets/issues/2412
[ "> I can provide a PR l8er...\r\n\r\nSee #2425 " ]
null
2,412
false
Add DOI badge to README
Once published the latest release, the DOI badge has been automatically generated by Zenodo.
https://github.com/huggingface/datasets/pull/2411
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2411", "html_url": "https://github.com/huggingface/datasets/pull/2411", "diff_url": "https://github.com/huggingface/datasets/pull/2411.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2411.patch", "merged_at": "2021-05-27T13:42...
2,411
true
fix #2391 add original answers in kilt-TriviaQA
cc @yjernite is it ok like this?
https://github.com/huggingface/datasets/pull/2410
[ "LGTM, but I'm not sure what's going on with the Unix tests @lhoestq ", "The CI error is unrelated to this PR, it's been fixed now on master.", "Thanks @PaulLerner !", "> #- [ ] - Hey![image](https://user-images.githubusercontent.com/71971234/121969638-00030e00-cd75-11eb-9512-25d32ac08051.jpeg)@fr[fr_fr**fr~~...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2410", "html_url": "https://github.com/huggingface/datasets/pull/2410", "diff_url": "https://github.com/huggingface/datasets/pull/2410.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2410.patch", "merged_at": "2021-06-14T17:29...
2,410
true
Add HF_ prefix to env var MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES
As mentioned in https://github.com/huggingface/datasets/pull/2399 the env var should be prefixed by HF_
https://github.com/huggingface/datasets/pull/2409
[ "I thought the renaming was suggested only for the env var, and not for the config variable... As you think is better! ;)", "I think it's better if they match, so that users understand directly that they're directly connected", "Well, if you're not concerned about back-compat here, perhaps it could be renamed a...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2409", "html_url": "https://github.com/huggingface/datasets/pull/2409", "diff_url": "https://github.com/huggingface/datasets/pull/2409.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2409.patch", "merged_at": "2021-05-27T09:33...
2,409
true
Fix head_qa keys
There were duplicate in the keys, as mentioned in #2382
https://github.com/huggingface/datasets/pull/2408
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2408", "html_url": "https://github.com/huggingface/datasets/pull/2408", "diff_url": "https://github.com/huggingface/datasets/pull/2408.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2408.patch", "merged_at": "2021-05-27T09:05...
2,408
true
.map() function got an unexpected keyword argument 'cache_file_name'
## Describe the bug I'm trying to save the result of datasets.map() to a specific file, so that I can easily share it among multiple computers without reprocessing the dataset. However, when I try to pass an argument 'cache_file_name' to the .map() function, it throws an error that ".map() function got an unexpected...
https://github.com/huggingface/datasets/issues/2407
[ "Hi @cindyxinyiwang,\r\nDid you try adding `.arrow` after `cache_file_name` argument? Here I think they're expecting something like that only for a cache file:\r\nhttps://github.com/huggingface/datasets/blob/e08362256fb157c0b3038437fc0d7a0bbb50de5c/src/datasets/arrow_dataset.py#L1556-L1558", "Hi ! `cache_file_nam...
null
2,407
false
Add guide on using task templates to documentation
Once we have a stable API on the text classification and question answering task templates, add a guide on how to use them in the documentation.
https://github.com/huggingface/datasets/issues/2406
[]
null
2,406
false
Add dataset tags
The dataset tags were provided by Peter Clark following the guide.
https://github.com/huggingface/datasets/pull/2405
[ "Thanks!" ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2405", "html_url": "https://github.com/huggingface/datasets/pull/2405", "diff_url": "https://github.com/huggingface/datasets/pull/2405.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2405.patch", "merged_at": "2021-05-26T16:40...
2,405
true
Paperswithcode dataset mapping
This is a continuation of https://github.com/huggingface/huggingface_hub/pull/43, encoded directly inside dataset cards. As discussed: - `paperswithcode_id: null` when the dataset doesn't exist on paperswithcode's side. - I've added this new key at the end of the yaml instead of ordering all keys alphabetically as...
https://github.com/huggingface/datasets/pull/2404
[ "messed up my branch, repushing", "live mapping can be found at https://huggingface.co/api/pwc/datasets-mapping and will be kept up to date going forward" ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2404", "html_url": "https://github.com/huggingface/datasets/pull/2404", "diff_url": "https://github.com/huggingface/datasets/pull/2404.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2404.patch", "merged_at": "2021-05-26T11:17...
2,404
true
Free datasets with cache file in temp dir on exit
This PR properly cleans up the memory-mapped tables that reference the cache files inside the temp dir. Since the built-in `_finalizer` of `TemporaryDirectory` can't be modified, this PR defines its own `TemporaryDirectory` class that accepts a custom clean-up function. Fixes #2402
https://github.com/huggingface/datasets/pull/2403
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2403", "html_url": "https://github.com/huggingface/datasets/pull/2403", "diff_url": "https://github.com/huggingface/datasets/pull/2403.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2403.patch", "merged_at": "2021-05-26T16:39...
2,403
true
PermissionError on Windows when using temp dir for caching
Currently, the following code raises a PermissionError on master if working on Windows: ```python # run as a script or call exit() in REPL to initiate the temp dir cleanup from datasets import * d = load_dataset("sst", split="train", keep_in_memory=False) set_caching_enabled(False) d.map(lambda ex: ex) ``` ...
https://github.com/huggingface/datasets/issues/2402
[]
null
2,402
false
load_dataset('natural_questions') fails with "ValueError: External features info don't match the dataset"
## Describe the bug load_dataset('natural_questions') throws ValueError ## Steps to reproduce the bug ```python from datasets import load_dataset datasets = load_dataset('natural_questions', split='validation[:10]') ``` ## Expected results Call to load_dataset returns data. ## Actual results ``` Using ...
https://github.com/huggingface/datasets/issues/2401
[ "I faced the similar problem. Downgrading datasets to 1.5.0 fixed it.", "Thanks for reporting, I'm looking into it", "I just opened #2438 to fix this :)", "Hi ! This has been fixed in the 1.8.0 release of `datasets`" ]
null
2,401
false
Concatenate several datasets with removed columns is not working.
## Describe the bug You can't concatenate datasets when you removed columns before. ## Steps to reproduce the bug ```python from datasets import load_dataset, concatenate_datasets wikiann= load_dataset("wikiann","en") wikiann["train"] = wikiann["train"].remove_columns(["langs","spans"]) wikiann["test"] =...
https://github.com/huggingface/datasets/issues/2400
[ "Hi,\r\n\r\ndid you fill out the env info section manually or by copy-pasting the output of the `datasets-cli env` command?\r\n\r\nThis code should work without issues on 1.6.2 version (I'm working on master (1.6.2.dev0 version) and can't reproduce this error).", "@mariosasko you are right I was still on `1.5.0`....
null
2,400
false
Add env variable for MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES
Add env variable for `MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES`. This will allow to turn off default behavior: loading in memory (and not caching) small datasets. Fix #2387.
https://github.com/huggingface/datasets/pull/2399
[ "Thank you for clarifying the precedence, @albertvillanova \r\n\r\nIsn't it typically the case where env vars have the highest precedence? \r\n\r\nIn my understanding the point of env vars is to be able to override software w/o needing to touch the code. \r\n\r\nPlease correct me if this is not so in the general ca...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2399", "html_url": "https://github.com/huggingface/datasets/pull/2399", "diff_url": "https://github.com/huggingface/datasets/pull/2399.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2399.patch", "merged_at": "2021-05-26T16:07...
2,399
true
News_commentary Dataset Translation Pairs are of Incorrect Language Specified Pairs
I used load_dataset to load the news_commentary dataset for "ar-en" translation pairs but found translations from Arabic to Hindi. ``` train_ds = load_dataset("news_commentary", "ar-en", split='train[:98%]') val_ds = load_dataset("news_commentary", "ar-en", split='train[98%:]') # filtering out examples that a...
https://github.com/huggingface/datasets/issues/2398
[ "These ranges seem to be valid English. Closing." ]
null
2,398
false
Fix number of classes in indic_glue sna.bn dataset
As read in the [paper](https://www.aclweb.org/anthology/2020.findings-emnlp.445.pdf), Table 11.
https://github.com/huggingface/datasets/pull/2397
[ "@lhoestq there are many things missing in the README.md file, but this correction is right despite not passing the validation tests...", "Yes indeed. We run the validation in all modified readme because we think that it is the time when contributors are the most likely to fix a dataset card - or it will never be...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2397", "html_url": "https://github.com/huggingface/datasets/pull/2397", "diff_url": "https://github.com/huggingface/datasets/pull/2397.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2397.patch", "merged_at": "2021-05-25T16:32...
2,397
true
strange datasets from OSCAR corpus
![image](https://user-images.githubusercontent.com/50871412/119260850-4f876b80-bc07-11eb-8894-124302600643.png) ![image](https://user-images.githubusercontent.com/50871412/119260875-675eef80-bc07-11eb-9da4-ee27567054ac.png) From the [official site ](https://oscar-corpus.com/), the Yue Chinese dataset should have 2.2K...
https://github.com/huggingface/datasets/issues/2396
[ "Hi ! Thanks for reporting\r\ncc @pjox is this an issue from the data ?\r\n\r\nAnyway we should at least mention that OSCAR could contain such contents in the dataset card, you're totally right @jerryIsHere ", "Hi @jerryIsHere , sorry for the late response! Sadly this is normal, the problem comes form fasttext's ...
null
2,396
false
`pretty_name` for dataset in YAML tags
I'm updating `pretty_name` for datasets in YAML tags as discussed with @lhoestq. Here are the first 10, please let me know if they're looking good. If dataset has 1 config, I've added `pretty_name` as `config_name: full_name_of_dataset` as config names were `plain_text`, `default`, `squad` etc (not so important in t...
https://github.com/huggingface/datasets/pull/2395
[ "Initially I removed the ` - ` since there was only one `pretty_name` per config but turns out it was breaking here in `from_yaml_string`https://github.com/huggingface/datasets/blob/74751e3f98c74d22c48c6beb1fab0c13b5dfd075/src/datasets/utils/metadata.py#L197 in `/utils/metadata.py`", "@lhoestq I guess this will a...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2395", "html_url": "https://github.com/huggingface/datasets/pull/2395", "diff_url": "https://github.com/huggingface/datasets/pull/2395.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2395.patch", "merged_at": null }
2,395
true
Update text classification template labels in DatasetInfo __post_init__
This PR implements the idea discussed in #2389 to update the `labels` of the `TextClassification` template in the `DatasetInfo.__post_init__`. The main reason for doing so is so avoid duplicating the label definitions in both `DatasetInfo.features` and `DatasetInfo.task_templates`. To avoid storing state in `Dataset...
https://github.com/huggingface/datasets/pull/2392
[ "If I'm not mistaken, one way to fix this would be to drop the task templates when copying the info by inserting `dataset.info.task_templates = None` before the `Dataset.cast` call in `Dataset.prepare_for_task`. Moreover, we should do this change independently of the KeyError being raised because currently the foll...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2392", "html_url": "https://github.com/huggingface/datasets/pull/2392", "diff_url": "https://github.com/huggingface/datasets/pull/2392.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2392.patch", "merged_at": "2021-05-28T11:37...
2,392
true
Missing original answers in kilt-TriviaQA
I previously opened an issue at https://github.com/facebookresearch/KILT/issues/42 but from the answer of @fabiopetroni it seems that the problem comes from HF-datasets ## Describe the bug The `answer` field in kilt-TriviaQA, e.g. `kilt_tasks['train_triviaqa'][0]['output']['answer']` contains a list of alternative ...
https://github.com/huggingface/datasets/issues/2391
[ "That could be useful indeed! Feel free to open a PR on the dataset card if you already have some code that runs, otherwise we'll take care of it soon :) ", "I can open a PR but there is 2 details to fix:\r\n- the name for the corresponding key (e.g. `original_answer`)\r\n- how to implement it: I’m not sure what ...
null
2,391
false
Add check for task templates on dataset load
This PR adds a check that the features of a dataset match the schema of each compatible task template.
https://github.com/huggingface/datasets/pull/2390
[ "LGTM now, thank you =)" ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2390", "html_url": "https://github.com/huggingface/datasets/pull/2390", "diff_url": "https://github.com/huggingface/datasets/pull/2390.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2390.patch", "merged_at": "2021-05-21T15:49...
2,390
true
Insert task templates for text classification
This PR inserts text-classification templates for datasets with the following properties: * Only one config * At most two features of `(Value, ClassLabel)` type Note that this misses datasets like `sentiment140` which only has `Value` type features - these will be handled in a separate PR
https://github.com/huggingface/datasets/pull/2389
[ "Update: found a few datasets that slipped through the net. Adding them shortly!", "You might have thought about this already, but would it make sense to use the `datasets.features.ClassLabel` values when possible instead of declaring the list once for the `feature` and once for the `template`?", "> You might h...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2389", "html_url": "https://github.com/huggingface/datasets/pull/2389", "diff_url": "https://github.com/huggingface/datasets/pull/2389.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2389.patch", "merged_at": "2021-05-28T15:26...
2,389
true
Incorrect URLs for some datasets
## Describe the bug It seems that the URLs for the following datasets are invalid: - [ ] `bn_hate_speech` has been renamed: https://github.com/rezacsedu/Bengali-Hate-Speech-Dataset/commit/c67ecfc4184911e12814f6b36901f9828df8a63a - [ ] `covid_tweets_japanese` has been renamed: http://www.db.info.gifu-u.ac.jp/covi...
https://github.com/huggingface/datasets/issues/2388
[]
null
2,388
false
datasets 1.6 ignores cache
Moving from https://github.com/huggingface/transformers/issues/11801#issuecomment-845546612 Quoting @VictorSanh: > > I downgraded datasets to `1.5.0` and printed `tokenized_datasets.cache_files` (L335): > > > `{'train': [{'filename': '/home/victor/.cache/huggingface/datasets/openwebtext10k/plain_text/1.0.0/...
https://github.com/huggingface/datasets/issues/2387
[ "Looks like there are multiple issues regarding this (#2386, #2322) and it's a WIP #2329. Currently these datasets are being loaded in-memory which is causing this issue. Quoting @mariosasko here for a quick fix:\r\n\r\n> set `keep_in_memory` to `False` when loading a dataset (`sst = load_dataset(\"sst\", keep_in_m...
null
2,387
false
Accessing Arrow dataset cache_files
## Describe the bug In datasets 1.5.0 the following code snippet would have printed the cache_files: ``` train_data = load_dataset('conll2003', split='train', cache_dir='data') print(train_data.cache_files[0]['filename']) ``` However, in the newest release (1.6.1), it prints an empty list. I also tried l...
https://github.com/huggingface/datasets/issues/2386
[ "Thanks @bhavitvyamalik for referencing the workaround. Setting `keep_in_memory=False` is working." ]
null
2,386
false
update citations
To update citations for [Offenseval_dravidiain](https://huggingface.co/datasets/offenseval_dravidian)
https://github.com/huggingface/datasets/pull/2385
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2385", "html_url": "https://github.com/huggingface/datasets/pull/2385", "diff_url": "https://github.com/huggingface/datasets/pull/2385.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2385.patch", "merged_at": "2021-05-21T12:38...
2,385
true
Add args description to DatasetInfo
Closes #2354 I am not sure what `post_processed` and `post_processing_size` correspond to, so have left them empty for now. I also took a guess at some of the other fields like `dataset_size` vs `size_in_bytes`, so might have misunderstood their meaning.
https://github.com/huggingface/datasets/pull/2384
[ "Thanks for the suggestions! I've included them and made a few minor tweaks along the way", "Please merge master into this branch to fix the CI, I just fixed metadata validation tests." ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2384", "html_url": "https://github.com/huggingface/datasets/pull/2384", "diff_url": "https://github.com/huggingface/datasets/pull/2384.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2384.patch", "merged_at": "2021-05-22T09:26...
2,384
true
Improve example in rounding docs
Improves the example in the rounding subsection of the Split API docs. With this change, it should more clear what's the difference between the `closest` and the `pct1_dropremainder` rounding.
https://github.com/huggingface/datasets/pull/2383
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2383", "html_url": "https://github.com/huggingface/datasets/pull/2383", "diff_url": "https://github.com/huggingface/datasets/pull/2383.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2383.patch", "merged_at": "2021-05-21T12:36...
2,383
true
DuplicatedKeysError: FAILURE TO GENERATE DATASET ! load_dataset('head_qa', 'en')
Hello everyone, I try to use head_qa dataset in [https://huggingface.co/datasets/viewer/?dataset=head_qa&config=en](url) ``` !pip install datasets from datasets import load_dataset dataset = load_dataset( 'head_qa', 'en') ``` When I write above load_dataset(.), it throws the following: ``` Duplicated...
https://github.com/huggingface/datasets/issues/2382
[]
null
2,382
false
add dataset card title
few of them were missed by me earlier which I've added now
https://github.com/huggingface/datasets/pull/2381
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2381", "html_url": "https://github.com/huggingface/datasets/pull/2381", "diff_url": "https://github.com/huggingface/datasets/pull/2381.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2381.patch", "merged_at": "2021-05-20T18:51...
2,381
true
maintain YAML structure reading from README
How YAML used be loaded earlier in the string (structure of YAML was affected because of this and YAML for datasets with multiple configs was not being loaded correctly): ``` annotations_creators: labeled_final: - expert-generated labeled_swap: - expert-generated unlabeled_final: - machine-generated language_c...
https://github.com/huggingface/datasets/pull/2380
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2380", "html_url": "https://github.com/huggingface/datasets/pull/2380", "diff_url": "https://github.com/huggingface/datasets/pull/2380.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2380.patch", "merged_at": "2021-05-19T13:08...
2,380
true
Disallow duplicate keys in yaml tags
Make sure that there's no duplidate keys in yaml tags. I added the check in the yaml tree constructor's method, so that the verification is done at every level in the yaml structure. cc @julien-c
https://github.com/huggingface/datasets/pull/2379
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2379", "html_url": "https://github.com/huggingface/datasets/pull/2379", "diff_url": "https://github.com/huggingface/datasets/pull/2379.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2379.patch", "merged_at": "2021-05-19T10:45...
2,379
true
Add missing dataset_infos.json files
Some of the datasets in `datasets` are missing a `dataset_infos.json` file, e.g. ``` [PosixPath('datasets/chr_en/chr_en.py'), PosixPath('datasets/chr_en/README.md')] [PosixPath('datasets/telugu_books/README.md'), PosixPath('datasets/telugu_books/telugu_books.py')] [PosixPath('datasets/reclor/README.md'), PosixPat...
https://github.com/huggingface/datasets/issues/2378
[]
null
2,378
false
ArrowDataset.save_to_disk produces files that cannot be read using pyarrow.feather
## Describe the bug A clear and concise description of what the bug is. ## Steps to reproduce the bug ```python from datasets import load_dataset from pyarrow import feather dataset = load_dataset('imdb', split='train') dataset.save_to_disk('dataset_dir') table = feather.read_table('dataset_dir/dataset.arro...
https://github.com/huggingface/datasets/issues/2377
[ "Hi ! This is because we are actually using the arrow streaming format. We plan to switch to the arrow IPC format.\r\nMore info at #1933 ", "Not sure if this was resolved, but I am getting a similar error when trying to load a dataset.arrow file directly: `ArrowInvalid: Not an Arrow file`", "Since we're using t...
null
2,377
false
Improve task api code quality
Improves the code quality of the `TaskTemplate` dataclasses. Changes: * replaces `return NotImplemented` with raise `NotImplementedError` * replaces `sorted` with `len` in the uniqueness check * defines `label2id` and `id2label` in the `TextClassification` template as properties * replaces the `object.__setatt...
https://github.com/huggingface/datasets/pull/2376
[ "Looks good thanks, what do you think @lewtun ?", "thanks for including the lazy `ClassLabel` class @mariosasko ! from my side this LGTM!" ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2376", "html_url": "https://github.com/huggingface/datasets/pull/2376", "diff_url": "https://github.com/huggingface/datasets/pull/2376.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2376.patch", "merged_at": "2021-05-25T15:30...
2,376
true
Dataset Streaming
# Dataset Streaming ## API Current API is ```python from datasets import load_dataset # Load an IterableDataset without downloading data snli = load_dataset("snli", streaming=True) # Access examples by streaming data print(next(iter(snli["train"]))) # {'premise': 'A person on a horse jumps over a br...
https://github.com/huggingface/datasets/pull/2375
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2375", "html_url": "https://github.com/huggingface/datasets/pull/2375", "diff_url": "https://github.com/huggingface/datasets/pull/2375.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2375.patch", "merged_at": "2021-06-23T16:35...
2,375
true
add `desc` to `tqdm` in `Dataset.map()`
Fixes #2330. Please let me know if anything is also required in this
https://github.com/huggingface/datasets/pull/2374
[ "Once this is merged, let's update `transformers` examples to use this new code. As currently all those tqdm bars are who knows what they are....\r\n\r\nhttps://github.com/huggingface/transformers/issues/11797", "Sure @stas00! Once this is merged let's discuss what all changes can be done on `transformers` side",...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2374", "html_url": "https://github.com/huggingface/datasets/pull/2374", "diff_url": "https://github.com/huggingface/datasets/pull/2374.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2374.patch", "merged_at": "2021-05-26T14:59...
2,374
true
Loading dataset from local path
I'm trying to load a local dataset with the code below ``` ds = datasets.load_dataset('my_script.py', data_files='corpus.txt', data_dir='/data/dir', cache_dir='.') ``` But internally a BuilderConfig is created, which tries to u...
https://github.com/huggingface/datasets/issues/2373
[ "Version below works, checked again in the docs, and data_files should be a path.\r\n```\r\nds = datasets.load_dataset('my_script.py', \r\n data_files='/data/dir/corpus.txt', \r\n cache_dir='.')\r\n```" ]
null
2,373
false
ConvQuestions benchmark added
Hello, I would like to integrate our dataset on conversational QA. The answers are grounded in the KG. The work was published in CIKM 2019 (https://dl.acm.org/doi/10.1145/3357384.3358016). We hope for further research on how to deal with the challenges of factoid conversational QA. Thanks! :)
https://github.com/huggingface/datasets/pull/2372
[ "Thanks for your helpful comments and suggestions! :)\r\nI integrated the additional fields, and extended some of the README/dataset card.\r\nAnd I actually realized that we had the cc-by-4.0 for the dataset, so this was also changed.", "I added the answers to the test set actually :)", "Oh great ! Let me rever...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2372", "html_url": "https://github.com/huggingface/datasets/pull/2372", "diff_url": "https://github.com/huggingface/datasets/pull/2372.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2372.patch", "merged_at": "2021-05-26T10:31...
2,372
true
Align question answering tasks with sub-domains
As pointed out by @thomwolf in #2255 we should consider breaking with the pipeline taxonomy of `transformers` to account for the various types of question-answering domains: > `question-answering` exists in two forms: abstractive and extractive question answering. > > we can keep a generic `question-answering` bu...
https://github.com/huggingface/datasets/issues/2371
[]
null
2,371
false
Adding HendrycksTest dataset
Adding Hendrycks test from https://arxiv.org/abs/2009.03300. I'm having a bit of trouble with dummy data creation because some lines in the csv files aren't being loaded properly (only the first entry loaded in a row of length 6). The dataset is loading just fine. Hope you can kindly help! Thank you!
https://github.com/huggingface/datasets/pull/2370
[ "@lhoestq Thank you for the review. I've made the suggested changes. There still might be some problems with dummy data though due to some csv loading issues (which I haven't found the cause to).", "I took a look at the dummy data and some csv lines were cropped. I fixed them :)" ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2370", "html_url": "https://github.com/huggingface/datasets/pull/2370", "diff_url": "https://github.com/huggingface/datasets/pull/2370.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2370.patch", "merged_at": "2021-05-31T16:37...
2,370
true
correct labels of conll2003
# What does this PR It fixes/extends the `ner_tags` for conll2003 to include all. Paper reference https://arxiv.org/pdf/cs/0306050v1.pdf Model reference https://huggingface.co/elastic/distilbert-base-cased-finetuned-conll03-english/blob/main/config.json
https://github.com/huggingface/datasets/pull/2369
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2369", "html_url": "https://github.com/huggingface/datasets/pull/2369", "diff_url": "https://github.com/huggingface/datasets/pull/2369.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2369.patch", "merged_at": "2021-05-18T08:27...
2,369
true
Allow "other-X" in licenses
This PR allows "other-X" licenses during metadata validation. @lhoestq
https://github.com/huggingface/datasets/pull/2368
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2368", "html_url": "https://github.com/huggingface/datasets/pull/2368", "diff_url": "https://github.com/huggingface/datasets/pull/2368.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2368.patch", "merged_at": "2021-05-17T16:36...
2,368
true
Remove getchildren from hyperpartisan news detection
`Element.getchildren()` is now deprecated in the ElementTree library (I think in python 3.9, so it still passes the automated tests which are using 3.6. But for those of us on bleeding-edge distros it now fails). https://bugs.python.org/issue29209
https://github.com/huggingface/datasets/pull/2367
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2367", "html_url": "https://github.com/huggingface/datasets/pull/2367", "diff_url": "https://github.com/huggingface/datasets/pull/2367.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2367.patch", "merged_at": "2021-05-17T14:07...
2,367
true
Json loader fails if user-specified features don't match the json data fields order
If you do ```python dataset = load_dataset("json", data_files=data_files, features=features) ``` Then depending on the order of the features in the json data field it fails: ```python [...] ~/Desktop/hf/datasets/src/datasets/packaged_modules/json/json.py in _generate_tables(self, files) 94 if s...
https://github.com/huggingface/datasets/issues/2366
[]
null
2,366
false
Missing ClassLabel encoding in Json loader
Currently if you want to load a json dataset this way ```python dataset = load_dataset("json", data_files=data_files, features=features) ``` Then if your features has ClassLabel types and if your json data needs class label encoding (i.e. if the labels in the json files are strings and not integers), then it would ...
https://github.com/huggingface/datasets/issues/2365
[]
null
2,365
false
README updated for SNLI, MNLI
Closes #2275. Mentioned about -1 labels in MNLI, SNLI and how they should be removed before training. @lhoestq `check_code_quality` test might fail for MNLI as the license name `other-Open Portion of the American National Corpus` is not a registered tag for 'licenses'
https://github.com/huggingface/datasets/pull/2364
[ "Regarding the license issue, I think we should allow it since it starts with `other-`. Cc @gchhablani what do you think ?", "@lhoestq I agree, I'll look into it." ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2364", "html_url": "https://github.com/huggingface/datasets/pull/2364", "diff_url": "https://github.com/huggingface/datasets/pull/2364.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2364.patch", "merged_at": "2021-05-17T13:34...
2,364
true
Fix web_nlg metadata
Our metadata storage system does not support `.` inside keys. cc @Pierrci
https://github.com/huggingface/datasets/pull/2362
[ "Hi ! `release_v2.1` and the others are dataset configuration names.\r\n\r\nThe configuration names are used to show the right code snippet in the UI to load the dataset.\r\nFor example if the parsing of the web_nlg tags worked correctly we would have:\r\n![image](https://user-images.githubusercontent.com/42851186/...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2362", "html_url": "https://github.com/huggingface/datasets/pull/2362", "diff_url": "https://github.com/huggingface/datasets/pull/2362.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2362.patch", "merged_at": null }
2,362
true
Preserve dtype for numpy/torch/tf/jax arrays
Fixes #625. This lets the user preserve the dtype of numpy array to pyarrow array which was getting lost due to conversion of numpy array -> list -> pyarrow array.
https://github.com/huggingface/datasets/pull/2361
[ "Hi @lhoestq, \r\nIt turns out that pyarrow `ListArray` are not recognized as list-like when we get output from `numpy_to_pyarrow_listarray`. This might cause tests to fail. If possible can we convert that `ListArray` output to list inorder for tests to pass? Under the hood it'll maintain the dtype as that of numpy...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2361", "html_url": "https://github.com/huggingface/datasets/pull/2361", "diff_url": "https://github.com/huggingface/datasets/pull/2361.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2361.patch", "merged_at": "2021-08-17T08:30...
2,361
true
Automatically detect datasets with compatible task schemas
See description of #2255 for details.
https://github.com/huggingface/datasets/issues/2360
[]
null
2,360
false
Allow model labels to be passed during task preparation
Models have a config with label2id. And we have the same for datasets with the ClassLabel feature type. At one point either the model or the dataset must sync with the other. It would be great to do that on the dataset side. For example for sentiment classification on amazon reviews with you could have these labels:...
https://github.com/huggingface/datasets/issues/2359
[ "We now have the `align_labels_with_mapping` method in the API for this purpose." ]
null
2,359
false
Roman Urdu Stopwords List
A list of most frequently used Roman Urdu words with different spellings and usages. This is a very basic effort to collect some basic stopwords for Roman Urdu to help efforts of analyzing text data in roman Urdu which makes up a huge part of daily internet interaction of Roman-Urdu users.
https://github.com/huggingface/datasets/pull/2358
[ "Hi ! Thanks for sharing :)\r\nI think the best place to share this is probably the `Languages at Hugging Face` section of the forum:\r\nhttps://discuss.huggingface.co/c/languages-at-hugging-face/15\r\n\r\nSince this is not a dataset, I'm closing this PR if you don't mind", "Thank you I will look into the link th...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2358", "html_url": "https://github.com/huggingface/datasets/pull/2358", "diff_url": "https://github.com/huggingface/datasets/pull/2358.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2358.patch", "merged_at": null }
2,358
true
Adding Microsoft CodeXGlue Datasets
Hi there, this is a new pull request to get the CodeXGlue datasets into the awesome HF datasets lib. Most of the work has been done in this PR #997 by the awesome @madlag. However, that PR has been stale for a while now and so I spoke with @lhoestq about finishing up the final mile and so he told me to open a new PR wi...
https://github.com/huggingface/datasets/pull/2357
[ "Oh one other thing. Mentioned in the PR was that I would need to regenerate the dataset_infos.json once the camel casing was done. However, I am unsure why this is the case since there is no reference to any object names in the dataset_infos.json file.\r\n\r\nIf it needs to be reran, I can try it do it on my own m...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2357", "html_url": "https://github.com/huggingface/datasets/pull/2357", "diff_url": "https://github.com/huggingface/datasets/pull/2357.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2357.patch", "merged_at": "2021-06-08T09:29...
2,357
true
normalized TOCs and titles in data cards
I started fixing some of the READMEs that were failing the tests introduced by @gchhablani but then realized that there were some consistent differences between earlier and newer versions of some of the titles (e.g. Data Splits vs Data Splits Sample Size, Supported Tasks vs Supported Tasks and Leaderboards). We also ha...
https://github.com/huggingface/datasets/pull/2355
[ "Oh right! I'd be in favor of still having the same TOC across the board, we can either leave it as is or add a `[More Info Needed]` `Contributions` Section wherever it's currently missing, wdyt?", "(I thought those were programmatically updated based on git history :D )", "Merging for now to avoid conflict sin...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2355", "html_url": "https://github.com/huggingface/datasets/pull/2355", "diff_url": "https://github.com/huggingface/datasets/pull/2355.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2355.patch", "merged_at": "2021-05-14T13:23...
2,355
true
Document DatasetInfo attributes
**Is your feature request related to a problem? Please describe.** As noted in PR #2255, the attributes of `DatasetInfo` are not documented in the [docs](https://huggingface.co/docs/datasets/package_reference/main_classes.html?highlight=datasetinfo#datasetinfo). It would be nice to do so :)
https://github.com/huggingface/datasets/issues/2354
[]
null
2,354
false
Update README vallidation rules
This PR allows unexpected subsections under third-level headings. All except `Contributions`. @lhoestq
https://github.com/huggingface/datasets/pull/2353
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2353", "html_url": "https://github.com/huggingface/datasets/pull/2353", "diff_url": "https://github.com/huggingface/datasets/pull/2353.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2353.patch", "merged_at": "2021-05-14T08:56...
2,353
true
Set to_json default to JSON lines
With this PR, the method `Dataset.to_json`: - is added to the docs - defaults to JSON lines
https://github.com/huggingface/datasets/pull/2352
[ "This is perfect, @albertvillanova - thank you! Tested it to work.\r\n\r\nMight it be a good idea to document the args to `to_json`?\r\n\r\nand also even a very basic progress bar? took 10min for 8M large records for `openwebtext` so perhaps some indication of it's being alive every min or so?", "@lhoestq I added...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2352", "html_url": "https://github.com/huggingface/datasets/pull/2352", "diff_url": "https://github.com/huggingface/datasets/pull/2352.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2352.patch", "merged_at": "2021-05-21T09:01...
2,352
true
simpllify faiss index save
Fixes #2350 In some cases, Faiss GPU index objects do not have neither "device" nor "getDevice". Possibly this happens when some part of the index is computed on CPU. In particular, this would happen with the index `OPQ16_128,IVF512,PQ32` (issue #2350). I did check it, but it is likely that `OPQ` or `PQ` transfor...
https://github.com/huggingface/datasets/pull/2351
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2351", "html_url": "https://github.com/huggingface/datasets/pull/2351", "diff_url": "https://github.com/huggingface/datasets/pull/2351.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2351.patch", "merged_at": "2021-05-17T13:41...
2,351
true
`FaissIndex.save` throws error on GPU
## Describe the bug After training an index with a factory string `OPQ16_128,IVF512,PQ32` on GPU, `.save_faiss_index` throws this error. ``` File "index_wikipedia.py", line 119, in <module> data["train"].save_faiss_index("text_emb", index_save_path) File "/home/vlialin/miniconda3/envs/cat/lib/python3.8...
https://github.com/huggingface/datasets/issues/2350
[ "Just in case, this is a workaround that I use in my code and it seems to do the job.\r\n\r\n```python\r\nif use_gpu_index:\r\n data[\"train\"]._indexes[\"text_emb\"].faiss_index = faiss.index_gpu_to_cpu(data[\"train\"]._indexes[\"text_emb\"].faiss_index)\r\n```" ]
null
2,350
false
Update task_ids for Ascent KB
This "other-other-knowledge-base" task is better suited for the dataset.
https://github.com/huggingface/datasets/pull/2349
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2349", "html_url": "https://github.com/huggingface/datasets/pull/2349", "diff_url": "https://github.com/huggingface/datasets/pull/2349.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2349.patch", "merged_at": "2021-05-17T10:48...
2,349
true
Add tests for dataset cards
Adding tests for dataset cards This PR will potentially remove the scripts being used for dataset tags and readme validation. Additionally, this will allow testing dataset readmes by providing the name as follows: ```bash pytest tests/test_dataset_cards.py::test_dataset_tags[fashion_mnist] ``` and ```bas...
https://github.com/huggingface/datasets/pull/2348
[ "@lhoestq\r\n\r\nShould I remove the scripts? or atleast remove running them from the CircleCI config?\r\n\r\nAlso, I hope it is okay that the combined method (metadata+content) is only a slow test, and for the Circle CI, I assume only non-slow tests are run? If yes, this would mean separate tests for content and m...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2348", "html_url": "https://github.com/huggingface/datasets/pull/2348", "diff_url": "https://github.com/huggingface/datasets/pull/2348.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2348.patch", "merged_at": "2021-05-21T12:10...
2,348
true
Add an API to access the language and pretty name of a dataset
It would be super nice to have an API to get some metadata of the dataset from the name and args passed to `load_dataset`. This way we could programmatically infer the language and the name of a dataset when creating model cards automatically in the Transformers examples scripts.
https://github.com/huggingface/datasets/issues/2347
[ "Hi ! With @bhavitvyamalik we discussed about having something like\r\n```python\r\nfrom datasets import load_dataset_card\r\n\r\ndataset_card = load_dataset_card(\"squad\")\r\nprint(dataset_card.metadata.pretty_name)\r\n# Stanford Question Answering Dataset (SQuAD)\r\nprint(dataset_card.metadata.languages)\r\n# [\...
null
2,347
false
Add Qasper Dataset
[Question Answering on Scientific Research Papers](https://allenai.org/project/qasper/home) Doing NLP on NLP papers to do NLP ♻️ I had to add it~ - [x] Add README (just gotta fill out some more ) - [x] Dataloader code - [x] Make dummy dataset - [x] generate dataset infos - [x] Tests
https://github.com/huggingface/datasets/pull/2346
[ "I saw that the README [template](https://github.com/huggingface/datasets/blob/master/templates/README.md) changed while I was working on this 😅 Some TOC titles may be different but I filled it to the best of my knowledge & readme quality check passes now.\r\nready for review @lhoestq " ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2346", "html_url": "https://github.com/huggingface/datasets/pull/2346", "diff_url": "https://github.com/huggingface/datasets/pull/2346.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2346.patch", "merged_at": "2021-05-18T12:28...
2,346
true
[Question] How to move and reuse preprocessed dataset?
Hi, I am training a gpt-2 from scratch using run_clm.py. I want to move and reuse the preprocessed dataset (It take 2 hour to preprocess), I tried to : copy path_to_cache_dir/datasets to new_cache_dir/datasets set export HF_DATASETS_CACHE="new_cache_dir/" but the program still re-preprocess the whole dataset...
https://github.com/huggingface/datasets/issues/2345
[ "@lhoestq @LysandreJik", "<s>Hi :) Can you share with us the code you used ?</s>\r\n\r\nEDIT: from https://github.com/huggingface/transformers/issues/11665#issuecomment-838348291 I understand you're using the run_clm.py script. Can you share your logs ?\r\n", "Also note that for the caching to work, you must re...
null
2,345
false
Is there a way to join multiple datasets in one?
**Is your feature request related to a problem? Please describe.** I need to join 2 datasets, one that is in the hub and another I've created from my files. Is there an easy way to join these 2? **Describe the solution you'd like** Id like to join them with a merge or join method, just like pandas dataframes. **Add...
https://github.com/huggingface/datasets/issues/2344
[ "Hi ! We don't have `join`/`merge` on a certain column as in pandas.\r\nMaybe you can just use the [concatenate_datasets](https://huggingface.co/docs/datasets/package_reference/main_classes.html?highlight=concatenate#datasets.concatenate_datasets) function.\r\n", "Hi! You can use `datasets_sql` for that now. As o...
null
2,344
false
Columns are removed before or after map function applied?
## Describe the bug According to the documentation when applying map function the [remove_columns ](https://huggingface.co/docs/datasets/processing.html#removing-columns) will be removed after they are passed to the function, but in the [source code](https://huggingface.co/docs/datasets/package_reference/main_classes....
https://github.com/huggingface/datasets/issues/2343
[ "Hi! Columns are removed **after** applying the function and **before** updating the examples with the function's output (as per the docs [here](https://huggingface.co/docs/datasets/package_reference/main_classes#datasets.Dataset.map.remove_columns)). I agree the docs on this should be more clear." ]
null
2,343
false
Docs - CER above 1
CER can actually be greater than 1.
https://github.com/huggingface/datasets/pull/2342
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2342", "html_url": "https://github.com/huggingface/datasets/pull/2342", "diff_url": "https://github.com/huggingface/datasets/pull/2342.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2342.patch", "merged_at": "2021-05-10T13:34...
2,342
true
Added the Ascent KB
Added the Ascent Commonsense KB of 8.9M assertions. - Paper: [Advanced Semantics for Commonsense Knowledge Extraction (WWW'21)](https://arxiv.org/abs/2011.00905) - Website: https://ascent.mpi-inf.mpg.de/ (I am the author of the dataset)
https://github.com/huggingface/datasets/pull/2341
[ "Thanks for approving it!" ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2341", "html_url": "https://github.com/huggingface/datasets/pull/2341", "diff_url": "https://github.com/huggingface/datasets/pull/2341.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2341.patch", "merged_at": "2021-05-11T09:16...
2,341
true
More consistent copy logic
Use `info.copy()` instead of `copy.deepcopy(info)`. `Features.copy` now creates a deep copy.
https://github.com/huggingface/datasets/pull/2340
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2340", "html_url": "https://github.com/huggingface/datasets/pull/2340", "diff_url": "https://github.com/huggingface/datasets/pull/2340.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2340.patch", "merged_at": "2021-05-11T08:58...
2,340
true
fixed download link for web_science
Fixes #2337. Should work with: `dataset = load_dataset("web_of_science", "WOS11967", ignore_verifications=True)`
https://github.com/huggingface/datasets/pull/2338
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2338", "html_url": "https://github.com/huggingface/datasets/pull/2338", "diff_url": "https://github.com/huggingface/datasets/pull/2338.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2338.patch", "merged_at": "2021-05-10T13:35...
2,338
true
NonMatchingChecksumError for web_of_science dataset
NonMatchingChecksumError when trying to download the web_of_science dataset. >NonMatchingChecksumError: Checksums didn't match for dataset source files: ['https://data.mendeley.com/datasets/9rw3vkcfy4/6/files/c9ea673d-5542-44c0-ab7b-f1311f7d61df/WebOfScience.zip?dl=1'] Setting `ignore_verfications=True` results...
https://github.com/huggingface/datasets/issues/2337
[ "I've raised a PR for this. Should work with `dataset = load_dataset(\"web_of_science\", \"WOS11967\", ignore_verifications=True)`once it gets merged into the main branch. Thanks for reporting this! " ]
null
2,337
false
Fix overflow issue in interpolation search
Fixes #2335 More info about this error can be found [here](https://stackoverflow.com/questions/53239890/why-do-i-keep-getting-this-error-runtimewarning-overflow-encountered-in-int-sc/53240100).
https://github.com/huggingface/datasets/pull/2336
[ "~~Seems like the CI failure is unrelated to this PR~~ (fixed with the merge). \r\n\r\n@lhoestq Can you please verify that everything is OK in terms of speed? Another solution is to change the offsets array dtype to np.int64 (but this doesn't scale in theory compared to Python integer which is unbound). I'm not sur...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2336", "html_url": "https://github.com/huggingface/datasets/pull/2336", "diff_url": "https://github.com/huggingface/datasets/pull/2336.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2336.patch", "merged_at": "2021-05-10T13:26...
2,336
true
Index error in Dataset.map
The following code, if executed on master, raises an IndexError (due to overflow): ```python >>> from datasets import * >>> d = load_dataset("bookcorpus", split="train") Reusing dataset bookcorpus (C:\Users\Mario\.cache\huggingface\datasets\bookcorpus\plain_text\1.0.0\44662c4a114441c35200992bea923b170e6f13f2f0beb7c...
https://github.com/huggingface/datasets/issues/2335
[]
null
2,335
false
Updating the DART file checksums in GEM
The DART files were just updated on the source GitHub https://github.com/Yale-LILY/dart/commit/34b3c872da4811523e334f1631e54ca8105dffab
https://github.com/huggingface/datasets/pull/2334
[ "@sebastianGehrmann " ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2334", "html_url": "https://github.com/huggingface/datasets/pull/2334", "diff_url": "https://github.com/huggingface/datasets/pull/2334.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2334.patch", "merged_at": "2021-05-07T22:18...
2,334
true
Fix duplicate keys
As noticed in https://github.com/huggingface/datasets/pull/2245, many datasets yield duplicate keys. Most of the time it was because the counter used for ids were reset at each new data file.
https://github.com/huggingface/datasets/pull/2333
[ "- @jplu " ]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2333", "html_url": "https://github.com/huggingface/datasets/pull/2333", "diff_url": "https://github.com/huggingface/datasets/pull/2333.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2333.patch", "merged_at": "2021-05-07T15:57...
2,333
true
Add note about indices mapping in save_to_disk docstring
https://github.com/huggingface/datasets/pull/2332
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2332", "html_url": "https://github.com/huggingface/datasets/pull/2332", "diff_url": "https://github.com/huggingface/datasets/pull/2332.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2332.patch", "merged_at": "2021-05-07T17:20...
2,332
true
Add Topical-Chat
## Adding a Dataset - **Name:** Topical-Chat - **Description:** a knowledge-grounded human-human conversation dataset where the underlying knowledge spans 8 broad topics and conversation partners don’t have explicitly defined roles - **Paper:** https://www.isca-speech.org/archive/Interspeech_2019/pdfs/3079.pdf - **...
https://github.com/huggingface/datasets/issues/2331
[]
null
2,331
false
Allow passing `desc` to `tqdm` in `Dataset.map()`
It's normal to have many `map()` calls, and some of them can take a few minutes, it would be nice to have a description on the progress bar. Alternative solution: Print the description before/after the `map()` call.
https://github.com/huggingface/datasets/issues/2330
[ "Hi @lhoestq,\r\nShould we change `desc` in [pbar](https://github.com/huggingface/datasets/blob/81fcf88172ed5e3026ef68aed4c0ec6980372333/src/datasets/arrow_dataset.py#L1860) to something meaningful?", "I think the user could pass the `desc` parameter to `map` so that it can be displayed in the tqdm progress bar, ...
null
2,330
false
Add cache dir for in-memory datasets
Adds the cache dir attribute to DatasetInfo as suggested by @lhoestq. Should fix #2322
https://github.com/huggingface/datasets/pull/2329
[ "Yes, having `cache_dir` as an attribute looks cleaner.\r\n\r\n\r\n\r\n", "Good job! Looking forward to this new feature! 🥂", "@lhoestq Sorry for the late reply. Yes, I'll start working on tests. Thanks for the detailed explanation of the current issues with caching (like the idea of adding the `use_caching` p...
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2329", "html_url": "https://github.com/huggingface/datasets/pull/2329", "diff_url": "https://github.com/huggingface/datasets/pull/2329.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2329.patch", "merged_at": null }
2,329
true
Add Matthews/Pearson/Spearman correlation metrics
Added three metrics: - The Matthews correlation coefficient (from sklearn) - The Pearson correlation coefficient (from scipy) - The Spearman correlation coefficient (from scipy) cc @sgugger
https://github.com/huggingface/datasets/pull/2328
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2328", "html_url": "https://github.com/huggingface/datasets/pull/2328", "diff_url": "https://github.com/huggingface/datasets/pull/2328.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2328.patch", "merged_at": "2021-05-06T16:58...
2,328
true
A syntax error in example
![image](https://user-images.githubusercontent.com/6883957/117315905-b47a5c00-aeba-11eb-91eb-b2a4a0212a56.png) Sorry to report with an image, I can't find the template source code of this snippet.
https://github.com/huggingface/datasets/issues/2327
[ "cc @beurkinger but I think this has been fixed internally and will soon be updated right ?", "This issue has been fixed." ]
null
2,327
false
Enable auto-download for PAN-X / Wikiann domain in XTREME
This PR replaces the manual download of the `PAN-X.lang` domains with an auto-download from a Dropbox link provided by the Wikiann author. We also add the relevant dummy data for these domains. While re-generating `dataset_infos.json` I ran into a `KeyError` in the `udpos.Arabic` domain so have included a fix for th...
https://github.com/huggingface/datasets/pull/2326
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2326", "html_url": "https://github.com/huggingface/datasets/pull/2326", "diff_url": "https://github.com/huggingface/datasets/pull/2326.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2326.patch", "merged_at": "2021-05-07T08:41...
2,326
true